Refactor rpc so all methods async, sendRawTransaction handles arrays#2520
Merged
Merged
Conversation
micahriggan
commented
Nov 7, 2019
| }); | ||
| }); | ||
| const txids = new Array<string>(); | ||
| const txs = typeof rawTx === 'string' ? [rawTx] : rawTx; |
micahriggan
force-pushed
the
refactor/broadcast-rpc-calls
branch
from
6faf6db to
79daa33
Compare
Contributor
|
Tested local bitcore-node with ETH multi-send. Works fine 👍
|
micahriggan
force-pushed
the
refactor/broadcast-rpc-calls
branch
from
79daa33 to
7104fc7
Compare
justinkook
reviewed
Nov 7, 2019
| const txids = new Array<string>(); | ||
| const rawTxs = typeof rawTx === 'string' ? [rawTx] : rawTx; | ||
| for (const tx of rawTxs) { | ||
| const txid = await this.getRPC(chain, network).sendTransaction(tx); |
Contributor
There was a problem hiding this comment.
needs error handling try catch or .catch
Contributor
Author
There was a problem hiding this comment.
This is for bitcoin, so I actually want it to throw if it fails
Merged
Contributor
|
This MR fixes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.