Feature(Eth) - Target ETH branch

[justinkook]

Requirements:

bitpay/bitcore#2281

Copay Set Up

Bitcore

1. npm i in bitcore/ root directory.

2. rm -rf node_modules package-lock.json in bitcore/packages/bitcore-wallet-client/ directory.

This is to remove symlinks / lerna bootstrap npm packages inside bitcore-wallet-client.

3. npm i inside bitcore/packages/bitcore-wallet-client/ to install the NPM Registry versions of packages.

Copay

1. rm -rf node_modules package-lock.json inside copay/ to remove old versions of bitcore-wallet-client.

2. bash pack-all.sh inside copay/ to install local bitcore-wallet-client.

Status:

• FIN

Steps to set up eth:

pack-all.sh assumes copay and bitcore folders to be a sibling and in the same folder.
ex:

dev/
   copay/
      src/
   bitcore/
      packages/

1. Run pack-all.sh bash script to npm install your local version of bitcore-wallet-client into Copay. This is done using npm pack command. Update package versions as needed.

Your package.json should include this:

    "bitcore-wallet-client": "file:../bitcore/packages/bitcore-wallet-client/bitcore-wallet-client-8.6.0.tgz",
...

2. Comment / Delete Content Security Policy in index-template.html:

 <!-- <meta http-equiv="Content-Security-Policy" content="default-src ... data:"> -->

2. Point BWS url to http://localhost:3232/bws/api in bws.ts.

3. When creating an ethereum wallet set BWS url to:
   http://localhost:3232/bws/api

Common Errors:

Uncaught TypeError: exists is not a function
Version guard duplicate version of bitcore-lib in bws.logs

Fix:
rm -rf node_modules/ && npm i

[codecov]

Codecov Report

Merging #9966 into eth will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              eth    #9966      +/-   ##
==========================================
+ Coverage   41.95%   42.08%   +0.13%     
==========================================
  Files         166      165       -1     
  Lines       15274    15166     -108     
  Branches     2105     2101       -4     
==========================================
- Hits         6408     6383      -25     
+ Misses       8503     8421      -82     
+ Partials      363      362       -1

Impacted Files	Coverage Δ
src/pages/add/add.ts	38.88% <0%> (-16.12%)	⬇️
...ngs/wallet-group-settings/wallet-group-settings.ts	29% <0%> (-2.14%)	⬇️
...up-settings/wallet-group-name/wallet-group-name.ts
src/pages/home/home.ts	38.14% <0%> (+0.09%)	⬆️
src/providers/persistence/persistence.ts	53.61% <0%> (+0.24%)	⬆️
src/providers/profile/profile.ts	17.58% <0%> (+0.29%)	⬆️
src/providers/bwc/bwc.ts	87.5% <0%> (+0.4%)	⬆️
src/pages/settings/settings.ts	39.31% <0%> (+0.53%)	⬆️
src/providers/key/key.ts	77.56% <0%> (+1.93%)	⬆️
src/pages/add/select-currency/select-currency.ts	61.53% <0%> (+36.53%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 313e9fd...f4945b0. Read the comment docs.

[Gamboster]

code ACK! Really a great job. Just a couple of small comments