Skip to content

Eth#2281

Merged
matiu merged 47 commits into
bitpay:ethfrom
justinkook:eth
Sep 17, 2019
Merged

Eth#2281
matiu merged 47 commits into
bitpay:ethfrom
justinkook:eth

Conversation

@justinkook
Copy link
Copy Markdown
Contributor

@justinkook justinkook commented Jul 18, 2019

BWC/BWS eth changes with key class MR and also ETH bitcore-node module changes.

Now includes ETH insight changes.

Uses mainly crypto-wallet-core for eth functionality.

Copay Set Up

Bitcore

  1. npm i in bitcore/ root directory.

  2. rm -rf node_modules package-lock.json in bitcore/packages/bitcore-wallet-client/ directory.

This is to remove symlinks / lerna bootstrap npm packages inside bitcore-wallet-client.

  1. npm i inside bitcore/packages/bitcore-wallet-client/ to install the NPM Registry versions of packages.

Copay

  1. rm -rf node_modules package-lock.json inside copay/ to remove old versions of bitcore-wallet-client.

  2. bash pack-all.sh inside copay/ to install local bitcore-wallet-client.

Status:

  • Need to remove { fee: gasPrice } from util.buildTx and txproposal.buildTx once CWC fix is published to npm.

Requirements:

  1. Parity dev chain:

--tracing on flag is required for internal contract transactions.

The following config flags are needed in the alias:

  • alias parity-test="parity --config dev --jsonrpc-cors=all --ws-origins=all --ws-apis=all --tracing on --base-path '/Users/justin/blockchains/dev/'"

More information on parity config:
https://wiki.parity.io/Configuring-Parity-Ethereum

  1. Add ETH to bitcore.config.json
"ETH": {
        "mainnet": {
          "provider": {
            "host": "127.0.0.1",
            "protocol": "ws",
            "port": 8546
          },
          "trustedPeers": [
            {
              "host": "127.0.0.1",
              "port": 30303
            }
          ]
        },

Steps to set up eth branch:

  1. Make eth point to local bitcore-node.
    packages/bitcore-wallet-service/src/config.ts
eth: {
      livenet: {
        url: 'http://localhost:3000',
      },
      testnet: {
        url: 'http://localhost:3000',
      },
  1. Point eth provider to local bitcore-node.
    packages/bitcore-wallet-service/src/lib/blockchainexplorer.ts
  eth: {
      livenet: 'http://localhost:3000',
      testnet: 'http://localhost:3000'
    }

Test on Copay using this PR:
https://github.com/bitpay/copay/pull/9966

To see BWC/BWS changes only:
micahriggan#24

@matiu
Copy link
Copy Markdown
Contributor

matiu commented Aug 12, 2019

Depends on:
#2325

Comment thread packages/bitcore-wallet-client/lib/key.js Outdated
Comment thread packages/bitcore-wallet-service/src/lib/blockchainexplorers/v8.ts
Comment thread packages/bitcore-wallet-client/lib/common/constants.js Outdated
Comment thread packages/bitcore-wallet-client/lib/api.js Outdated
Comment thread packages/bitcore-wallet-service/src/lib/server.ts Outdated
@justinkook justinkook force-pushed the eth branch 2 times, most recently from 261287a to 4e6d8ee Compare August 23, 2019 18:21
@justinkook justinkook closed this Aug 23, 2019
@justinkook justinkook reopened this Aug 23, 2019
Comment thread packages/crypto-wallet-core/src/transactions/erc20/index.ts
…iming

Making the websocket tests more stable
remove b-lib and b-lib-cash from package.json
@justinkook justinkook force-pushed the eth branch 2 times, most recently from ee8ada7 to bcc514d Compare September 4, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants