This repository was archived by the owner on Mar 7, 2026. It is now read-only.
Fix: JTAG-TAP cleanup#1293
Merged
Merged
Conversation
…rrent jtagtap header
…e current jtagtap header
…rrent jtagtap header
…q and cleaned up the work loops
…q and cleaned up the work loops
…shift_dr} as using the global instance is fine
dragonmux
force-pushed
the
fix/jtag-tap-cleanup
branch
from
92dad5f to
b2077ff
Compare
esden
approved these changes
Nov 18, 2022
Member
esden
left a comment
esden
left a comment
There was a problem hiding this comment.
It logically LGTM. It needs practical testing. But I will lean towards optimistic merging here. We can shake out any potential regressions in the stabilization period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description
In this PR we address some conformity issues with the firmware-side JTAG-TAP code and remove a point of confusion (the
jtag_proc_t *jpparameters in the JTAG abstraction layer). This finishes what was started in #1118 and #1131Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues