Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Code Coverage Report
|
There was a problem hiding this comment.
Pull request overview
This PR reintegrates the preconditions DSL work and restores propagation of planning-time soft precondition path warnings onto individual IdLE.PlanStep objects so downstream consumers can reason about step-level warnings.
Changes:
- Attach precondition-related planning warnings to each normalized
IdLE.PlanStepinConvertTo-IdleWorkflowSteps. - Extend
Export-IdlePlantests to assert step-level warnings exist and include the expected warning code.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/IdLE.Core/Private/ConvertTo-IdleWorkflowSteps.ps1 |
Filters plan warnings for the current step and assigns them to the step’s Warnings property. |
tests/Core/Export-IdlePlan.Tests.ps1 |
Adds assertions verifying warnings are present on the planned step and include the expected code. |
|
@copilot pls fix the failing tests. |
|
@blindzero I've opened a new pull request, #243, to work on those changes. Once the pull request is ready, I'll request review from you. |
…step Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Fix per-step precondition warning propagation (empty ArrayList collapsed to null by pipeline)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot now the warning on preconditions is always issued. Step Warning: The assumption is
|
|
@blindzero I've opened a new pull request, #245, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Enforce strict path validation for precondition operators at execution time
|
@copilot the warning / error behavior still doesnt work as intended for unresolved Request Paths:
The desired state is for unresolved request. paths
|
|
@blindzero I've opened a new pull request, #246, to work on those changes. Once the pull request is ready, I'll request review from you. |
- Add Write-Warning to Assert-IdleConditionPathsResolvable so missing Request.Context.* paths in preconditions emit a visible terminal warning during New-IdlePlan in addition to being stored in plan.Warnings - Rename Normalize-IdleExchangeOnlineAutoReplyMessage to Format-IdleExchangeOnlineAutoReplyMessage (PSUseApprovedVerbs) - Apply Invoke-Formatter to fix PSUseConsistentWhitespace and PSUseConsistentIndentation across 7 source files Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Re-apply Invoke-Formatter to New-IdleExchangeOnlineProvider.ps1 to produce zero PSUseConsistentIndentation violations (fixes #2865282671) - Fix Invoke-IdlePlanObject.ps1 line 121 continuation indent to match formatter expectation (no extra 4 spaces on the -or continuation) - Update ExchangeOnlineProvider.Tests.ps1 BeforeAll: rename variable $normalizeFunctionPath -> $formatHelperPath to match file name, and clarify comment with consistent normalization/format terminology Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Fix precondition plan-time warning visibility and resolve PSSA CI alerts
|
@blindzero I've opened a new pull request, #247, to work on those changes. Once the pull request is ready, I'll request review from you. |
…output Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Co-authored-by: blindzero <13959569+blindzero@users.noreply.github.com>
Fix PSSA indentation, add per-step export warnings, beautify PSSA tool output
Motivation
codex/review-preconditions-dsl-for-duplicates-0x5tiybranch into a fresh task branch based onmainwhile preserving the warning behavior introduced by that work.PlanStepso downstream consumers and theExport-IdlePlanartifact include step-level warnings for CI/policy checks.Description
codex/reintegrate-preconditions-warning-fixfromorigin/mainand merged the preconditions DSL branch, resolving conflicts and keeping the main baseline where appropriate.src/IdLE.Core/Private/ConvertTo-IdleWorkflowSteps.ps1by initializing$preconditionWarningsand populating it by filteringPlanningContext.Plan.Warningsfor warnings whoseStepequals the current step andSourceequalsPrecondition, then assigning the collection to the step'sWarningsproperty. (file changed:ConvertTo-IdleWorkflowSteps.ps1)tests/Core/Export-IdlePlan.Tests.ps1to verify that per-step warnings are present and include the expectedPreconditionContextPathUnresolvedAtPlancode on the affected step. (file changed:tests/Core/Export-IdlePlan.Tests.ps1)Testing
git commitsucceeded).pwsh -NoLogo -NoProfile -Command "Invoke-Pester -Path ./tests -Output Detailed"but the environment lackspwshso Pester could not be executed (bash: command not found: pwsh).Codex Task