Fix per-step precondition warning propagation (empty ArrayList collapsed to null by pipeline)

[Copilot]

$plan.Steps[n].Warnings was always empty despite warnings being correctly appended to $plan.Warnings. Per-step warning tracking in ConvertTo-IdleWorkflowSteps silently no-oped because PowerShell's output pipeline collapses an empty ArrayList to $null when returned from a function — so Get-IdlePropertyValue(..., 'Warnings') returned $null before any warnings existed, making $planWarningsCanTrackCount false.

Changes

• ConvertTo-IdleWorkflowSteps.ps1 — replace Get-IdlePropertyValue call for the plan Warnings sink with direct PSObject.Properties access (same pattern already used in ConvertTo-IdleWorkflowStepPreconditionSettings), which preserves the live ArrayList reference regardless of whether it is empty. Also tightened the guard to $planWarnings -is [System.Collections.IList].

# Before — collapses empty ArrayList to $null via pipeline unrolling
$planWarnings = Get-IdlePropertyValue -Object $PlanningContext.Plan -Name 'Warnings'
$planWarningsCanTrackCount = $null -ne $planWarnings -and $null -ne $planWarnings.PSObject.Properties['Count']

# After — direct property access preserves live reference
$planWarnings = $null
$planObj = $PlanningContext.Plan
if ($null -ne $planObj) {
    if ($planObj -is [System.Collections.IDictionary]) {
        if ($planObj.Contains('Warnings')) { $planWarnings = $planObj['Warnings'] }
    } else {
        $wProp = $planObj.PSObject.Properties['Warnings']
        if ($null -ne $wProp) { $planWarnings = $wProp.Value }
    }
}
$planWarningsCanTrackCount = $planWarnings -is [System.Collections.IList]

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[github-actions]

Code Coverage Report

Overall Project	73.91%	🍏

There is no coverage information present for the Files changed

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[Copilot]

Pull request overview

Fixes per-step precondition warning propagation during planning so that $plan.Steps[n].Warnings correctly reflects warnings appended to $plan.Warnings, even when the warnings list starts empty.

Changes:

• Replaces Get-IdlePropertyValue usage for accessing the plan Warnings sink with direct property access to preserve the live ArrayList reference.
• Tightens the tracking guard from “has Count property” to “is an IList”, matching the intent of list-based warning tracking.

Comments suppressed due to low confidence (1)

src/IdLE.Core/Private/ConvertTo-IdleWorkflowSteps.ps1:139

• This block duplicates (and can drift from) both Get-IdlePropertyValue and the similar Warnings-sink extraction logic in ConvertTo-IdleWorkflowStepPreconditionSettings. Consider centralizing this into a small private helper (or adjusting Get-IdlePropertyValue to return empty collections without pipeline enumeration) so future fixes don’t need to be applied in multiple places.

        $planWarnings = $null
        $planObj = $PlanningContext.Plan
        if ($null -ne $planObj) {
            if ($planObj -is [System.Collections.IDictionary]) {
                if ($planObj.Contains('Warnings')) { $planWarnings = $planObj['Warnings'] }
            } else {
                $wProp = $planObj.PSObject.Properties['Warnings']
                if ($null -ne $wProp) { $planWarnings = $wProp.Value }
            }