fix(cli): handle Reasoning content and fix streaming thinking display#7296
Merged
DOsinga merged 1 commit intoblock:mainfrom Feb 18, 2026
Merged
fix(cli): handle Reasoning content and fix streaming thinking display#7296DOsinga merged 1 commit intoblock:mainfrom
DOsinga merged 1 commit intoblock:mainfrom
Conversation
Add MessageContent::Reasoning to both CLI renderers. Fix streaming to print a single "Thinking:" header then stream dimmed text, instead of repeating the header per chunk. Change-Id: I52cd5d567aa758a4b630d28fba235395913bb61c Signed-off-by: rabi <ramishra@redhat.com>
DOsinga
approved these changes
Feb 18, 2026
| theme: Theme, | ||
| ) { | ||
| if should_show_thinking() { | ||
| flush_markdown_buffer(buffer, theme); |
Collaborator
There was a problem hiding this comment.
presumably this doesn't happen half way rendering of markdown? not that we could do much about it
jh-block
added a commit
that referenced
this pull request
Feb 18, 2026
* origin/main: docs: remove ALPHA_FEATURES flag from documentation (#7315) docs: escape variable syntax in recipes (#7314) docs: update OTel environment variable and config guides (#7221) docs: system proxy settings (#7311) docs: add Summon extension tutorial and update Skills references (#7310) docs: agent session id (#7289) fix(gemini-cli): restore streaming lost in #7247 (#7291) Update more instructions (#7305) feat: add Moonshot and Kimi Code declarative providers (#7304) fix(cli): handle Reasoning content and fix streaming thinking display (#7296) feat: add GOOSE_SUBAGENT_MODEL and GOOSE_SUBAGENT_PROVIDER config options (#7277) fix(openai): support "reasoning" field alias in streaming deltas (#7294) fix(ui): revert app-driven iframe width and send containerDimensions per ext-apps spec (#7300) New OpenAI event (#7301) ci: add fork guards to scheduled workflows (#7292)
michaelneale
added a commit
that referenced
this pull request
Feb 19, 2026
* main: (54 commits) docs: add monitoring subagent activity section (#7323) docs: document Desktop UI recipe editing for model/provider and extensions (#7327) docs: add CLAUDE_THINKING_BUDGET and CLAUDE_THINKING_ENABLED environm… (#7330) fix: display 'Code Mode' instead of 'code_execution' in CLI (#7321) docs: add Permission Policy documentation for MCP Apps (#7325) update RPI plan prompt (#7326) docs: add CLI syntax highlighting theme customization (#7324) fix(cli): replace shell-based update with native Rust implementation (#7148) docs: rename Code Execution extension to Code Mode extension (#7316) docs: remove ALPHA_FEATURES flag from documentation (#7315) docs: escape variable syntax in recipes (#7314) docs: update OTel environment variable and config guides (#7221) docs: system proxy settings (#7311) docs: add Summon extension tutorial and update Skills references (#7310) docs: agent session id (#7289) fix(gemini-cli): restore streaming lost in #7247 (#7291) Update more instructions (#7305) feat: add Moonshot and Kimi Code declarative providers (#7304) fix(cli): handle Reasoning content and fix streaming thinking display (#7296) feat: add GOOSE_SUBAGENT_MODEL and GOOSE_SUBAGENT_PROVIDER config options (#7277) ...
michaelneale
added a commit
that referenced
this pull request
Feb 19, 2026
…7302) The catch-all match arm in render_message() and render_message_streaming() printed 'WARNING: Message content type could not be rendered' to stdout via println!. This pollutes stdout when piping or scripting (e.g. with --quiet --text), breaking CI pipelines that expect only model output on stdout. Changes: - Replace println! with eprintln! so the warning goes to stderr, following the POSIX convention that stdout is for program output and stderr is for diagnostics/warnings. - Replace the wildcard (_ =>) match arms with explicit matches for ToolConfirmationRequest and FrontendToolRequest. This ensures that if a new MessageContent variant is added in the future, the compiler will flag the missing match arm instead of silently falling through. Note: The primary cause of #7302 (ReasoningContent not being handled, causing a flood of warnings) was already fixed by commit f481484 (PR #7296). This commit addresses the secondary concern from the issue: warnings should never be printed to stdout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add MessageContent::Reasoning to both CLI renderers. Fix streaming to print a single "Thinking:" header then stream dimmed text, instead of repeating the header per chunk.
Type of Change
AI Assistance
Testing
Tested locally.