Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the installation instructions for macOS desktop app downloads in GitHub workflow files for release candidates and PR comments. The changes replace old manual instructions with a reference to the pre-release.sh script that automates the download, extraction, quarantine removal, and signing process. Additionally, the PR corrects the description of the Intel x64 build from "signed" to "unsigned".
Changes:
- Updated macOS app installation instructions to reference the
pre-release.shautomation script - Corrected Intel x64 build description from "signed" to "unsigned"
- Standardized manual installation steps across both workflow files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/release-branches.yml |
Updated installation instructions for ARM64 release candidate builds to reference pre-release.sh script and include manual fallback steps |
.github/workflows/pr-comment-bundle-intel.yml |
Updated installation instructions for Intel x64 PR builds, corrected build status to "unsigned", and added pre-release.sh script reference with manual fallback |
| `./scripts/pre-release.sh` | ||
|
|
||
| script which will download the latest release (or you can specify the release you need), does the | ||
| unzip, xattr to get it out of quarantine and signs it. |
There was a problem hiding this comment.
The instructions state that the script "does the unzip, xattr to get it out of quarantine and signs it" (line 36), but the manual instructions below say signing is only optional (line 43). However, looking at the script itself, it always performs signing at line 75 without any conditional logic. The description should be accurate - the script does sign the app unconditionally.
| script which will download the latest release (or you can specify the release you need), does the | ||
| unzip, xattr to get it out of quarantine and signs it. |
There was a problem hiding this comment.
The instructions state that the script "does the unzip, xattr to get it out of quarantine and signs it" (line 102), but the manual instructions below say signing is only optional (line 110). However, looking at the script itself, it always performs signing at line 75 without any conditional logic. The description should be accurate - the script does sign the app unconditionally.
| script which will download the latest release (or you can specify the release you need), does the | ||
| unzip, xattr to get it out of quarantine and signs it. | ||
|
|
There was a problem hiding this comment.
Grammar issue: "does the unzip" should be "does the unzipping" or "unzips". Similarly, "xattr to get it out of quarantine and signs it" should be "runs xattr to get it out of quarantine, and signs it".
| script which will download the latest release (or you can specify the release you need), does the | |
| unzip, xattr to get it out of quarantine and signs it. | |
| script which will download the latest release (or you can specify the release you need), unzips it, runs xattr to get it out of quarantine, and signs it. | |
| script which will download the latest release (or you can specify the release you need), does the | ||
| unzip, xattr to get it out of quarantine and signs it. |
There was a problem hiding this comment.
Grammar issue: "does the unzip" should be "does the unzipping" or "unzips". Similarly, "xattr to get it out of quarantine and signs it" should be "runs xattr to get it out of quarantine, and signs it".
| script which will download the latest release (or you can specify the release you need), does the | |
| unzip, xattr to get it out of quarantine and signs it. | |
| script which will download the latest release (or you can specify the release you need), unzips it, | |
| runs xattr to get it out of quarantine, and signs it. |
* origin/main: docs: remove ALPHA_FEATURES flag from documentation (#7315) docs: escape variable syntax in recipes (#7314) docs: update OTel environment variable and config guides (#7221) docs: system proxy settings (#7311) docs: add Summon extension tutorial and update Skills references (#7310) docs: agent session id (#7289) fix(gemini-cli): restore streaming lost in #7247 (#7291) Update more instructions (#7305) feat: add Moonshot and Kimi Code declarative providers (#7304) fix(cli): handle Reasoning content and fix streaming thinking display (#7296) feat: add GOOSE_SUBAGENT_MODEL and GOOSE_SUBAGENT_PROVIDER config options (#7277) fix(openai): support "reasoning" field alias in streaming deltas (#7294) fix(ui): revert app-driven iframe width and send containerDimensions per ext-apps spec (#7300) New OpenAI event (#7301) ci: add fork guards to scheduled workflows (#7292)
* main: (54 commits) docs: add monitoring subagent activity section (#7323) docs: document Desktop UI recipe editing for model/provider and extensions (#7327) docs: add CLAUDE_THINKING_BUDGET and CLAUDE_THINKING_ENABLED environm… (#7330) fix: display 'Code Mode' instead of 'code_execution' in CLI (#7321) docs: add Permission Policy documentation for MCP Apps (#7325) update RPI plan prompt (#7326) docs: add CLI syntax highlighting theme customization (#7324) fix(cli): replace shell-based update with native Rust implementation (#7148) docs: rename Code Execution extension to Code Mode extension (#7316) docs: remove ALPHA_FEATURES flag from documentation (#7315) docs: escape variable syntax in recipes (#7314) docs: update OTel environment variable and config guides (#7221) docs: system proxy settings (#7311) docs: add Summon extension tutorial and update Skills references (#7310) docs: agent session id (#7289) fix(gemini-cli): restore streaming lost in #7247 (#7291) Update more instructions (#7305) feat: add Moonshot and Kimi Code declarative providers (#7304) fix(cli): handle Reasoning content and fix streaming thinking display (#7296) feat: add GOOSE_SUBAGENT_MODEL and GOOSE_SUBAGENT_PROVIDER config options (#7277) ...
2 participants
Summary
Noticed the instructions for the actuall release candidate had not been updated