Skip to content

Improve chat scrolling and multiline composer#14

Merged
wesbillman merged 4 commits into
mainfrom
codex/chat-scroll-and-multiline-composer
Mar 10, 2026
Merged

Improve chat scrolling and multiline composer#14
wesbillman merged 4 commits into
mainfrom
codex/chat-scroll-and-multiline-composer

Conversation

@wesbillman
Copy link
Copy Markdown
Collaborator

@wesbillman wesbillman commented Mar 10, 2026

Summary

  • improve chat timeline scrolling so bottom-pinned conversations stay pinned on new messages while scrolled-up readers keep their place, including during composer resize changes
  • switch the message composer to a multiline textarea with Enter for newlines, Cmd/Ctrl+Enter to send, a 4-row cap, and a simplified Send button shortcut hint
  • add smoke and relay-backed Playwright coverage for pinned-bottom scrolling, scrolled-up behavior, composer growth, and multiline sending

Testing

  • pnpm check
  • pnpm typecheck
  • pnpm build
  • pnpm playwright test --project=smoke tests/e2e/smoke.spec.ts
  • pnpm playwright test --project=integration tests/e2e/stream.spec.ts

@wesbillman wesbillman merged commit 758049c into main Mar 10, 2026
8 checks passed
@wesbillman wesbillman deleted the codex/chat-scroll-and-multiline-composer branch March 10, 2026 16:46
tlongwell-block added a commit that referenced this pull request Mar 11, 2026
@tlongwell-block
Merge origin/main into acp
3ee3c00 
* origin/main:
  feat: soft-delete for events/channels, enriched API responses, NIP-29 group management (#17)
  feat: Channel management, messaging, threads, DMs, reactions, and NIP-29 support (#16)
  Improve chat scrolling and multiline composer (#14)
  chore: remove redundant inline comments across all crates (#13)
  Initial backend revisions, workflow expansion (#5)
  Add desktop Home feed (#12)
  Add desktop Playwright e2e harness (#11)
  Update desktop icon and persist window state (#9)
  feat: add channel creation flow (#8)
wpfleger96 added a commit that referenced this pull request May 22, 2026
@wpfleger96
refactor(desktop): consolidate ACP provider discovery and address rev…
6b8b0f8 
…iew findings

The original implementation created a second parallel Tauri command
(discover_all_acp_providers) alongside the existing one to avoid
changing the return type. This produced two commands, two hooks, two
query keys, and two raw type converters. Consolidates into a single
command returning the full catalog, with a useAvailableAcpProviders
hook that type-narrows for callers needing non-null command/binaryPath.

Also fixes: pipe deadlock in install command (#1), UTF-8 truncation
panic (#2/#4), adds install concurrency guard (#11), exact provider ID
match (#15), error display stdout fallback (#5), success banner
suppression when already available (#12), misleading re-run text (#13),
IIFE refactor in PersonaDialog (#14), hidden internal query lift (#7),
configurable e2e mocks (#9), shared raw type exports (#8), and
classify_provider unit tests (#10).
wpfleger96 added a commit that referenced this pull request May 22, 2026
@wpfleger96
refactor(desktop): consolidate ACP provider discovery and address rev…
9c7747d 
…iew findings

The original implementation created a second parallel Tauri command
(discover_all_acp_providers) alongside the existing one to avoid
changing the return type. This produced two commands, two hooks, two
query keys, and two raw type converters. Consolidates into a single
command returning the full catalog, with a useAvailableAcpProviders
hook that type-narrows for callers needing non-null command/binaryPath.

Also fixes: pipe deadlock in install command (#1), UTF-8 truncation
panic (#2/#4), adds install concurrency guard (#11), exact provider ID
match (#15), error display stdout fallback (#5), success banner
suppression when already available (#12), misleading re-run text (#13),
IIFE refactor in PersonaDialog (#14), hidden internal query lift (#7),
configurable e2e mocks (#9), shared raw type exports (#8), and
classify_provider unit tests (#10).
wpfleger96 added a commit that referenced this pull request May 22, 2026
@wpfleger96
refactor(desktop): consolidate ACP provider discovery and address rev…
3b26a0d 
…iew findings

The original implementation created a second parallel Tauri command
(discover_all_acp_providers) alongside the existing one to avoid
changing the return type. This produced two commands, two hooks, two
query keys, and two raw type converters. Consolidates into a single
command returning the full catalog, with a useAvailableAcpProviders
hook that type-narrows for callers needing non-null command/binaryPath.

Also fixes: pipe deadlock in install command (#1), UTF-8 truncation
panic (#2/#4), adds install concurrency guard (#11), exact provider ID
match (#15), error display stdout fallback (#5), success banner
suppression when already available (#12), misleading re-run text (#13),
IIFE refactor in PersonaDialog (#14), hidden internal query lift (#7),
configurable e2e mocks (#9), shared raw type exports (#8), and
classify_provider unit tests (#10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesbillman