Skip to content

Add desktop search and result anchors#15

Merged
wesbillman merged 1 commit into
mainfrom
codex/add-desktop-search
Mar 10, 2026
Merged

Add desktop search and result anchors#15
wesbillman merged 1 commit into
mainfrom
codex/add-desktop-search

Conversation

@wesbillman
Copy link
Copy Markdown
Collaborator

@wesbillman wesbillman commented Mar 10, 2026

Summary

  • add relay-backed desktop search with a Cmd+K dialog and replace the old sidebar jump input
  • wire relay and Tauri event lookup so opening a search result lands on the matched message in the right channel
  • extend the desktop e2e bridge and smoke coverage for search result navigation

Testing

  • cargo check --workspace
  • cd desktop && pnpm check
  • cd desktop && pnpm typecheck
  • cd desktop && pnpm build
  • cd desktop && pnpm exec playwright test --project=smoke --grep "loads the exact result"
  • pre-push hook (desktop-check, desktop-build, desktop-tauri-check, rust-fmt, rust-clippy, rust-tests)

@wesbillman
Copy link
Copy Markdown
Collaborator Author

wesbillman commented Mar 10, 2026

Screenshot 2026-03-10 at 10 30 12 AM Screenshot 2026-03-10 at 10 33 33 AM Screenshot 2026-03-10 at 10 33 53 AM

@wesbillman wesbillman force-pushed the codex/add-desktop-search branch from 91b7464 to 475bd3d Compare March 10, 2026 19:02
@wesbillman wesbillman force-pushed the codex/add-desktop-search branch from 475bd3d to 4fe5564 Compare March 10, 2026 20:42
@wesbillman wesbillman merged commit 1be84cc into main Mar 10, 2026
8 checks passed
@wesbillman wesbillman deleted the codex/add-desktop-search branch March 10, 2026 20:54
tlongwell-block added a commit that referenced this pull request Mar 11, 2026
@tlongwell-block
Merge origin/main into acp
50ac8a2 
* origin/main:
  Migrate channel scoping to h tags (#22)
  Remove IF NOT EXISTS from migrations and drop mysql CLI fallback (#19)
  fix: resolve 10 E2E bugs + add desktop Playwright tests (#21)
  Add desktop search and result anchors (#15)
  fix: mcp and desktop communication (#18)
wpfleger96 added a commit that referenced this pull request May 22, 2026
@wpfleger96
refactor(desktop): consolidate ACP provider discovery and address rev…
6b8b0f8 
…iew findings

The original implementation created a second parallel Tauri command
(discover_all_acp_providers) alongside the existing one to avoid
changing the return type. This produced two commands, two hooks, two
query keys, and two raw type converters. Consolidates into a single
command returning the full catalog, with a useAvailableAcpProviders
hook that type-narrows for callers needing non-null command/binaryPath.

Also fixes: pipe deadlock in install command (#1), UTF-8 truncation
panic (#2/#4), adds install concurrency guard (#11), exact provider ID
match (#15), error display stdout fallback (#5), success banner
suppression when already available (#12), misleading re-run text (#13),
IIFE refactor in PersonaDialog (#14), hidden internal query lift (#7),
configurable e2e mocks (#9), shared raw type exports (#8), and
classify_provider unit tests (#10).
wpfleger96 added a commit that referenced this pull request May 22, 2026
@wpfleger96
refactor(desktop): consolidate ACP provider discovery and address rev…
9c7747d 
…iew findings

The original implementation created a second parallel Tauri command
(discover_all_acp_providers) alongside the existing one to avoid
changing the return type. This produced two commands, two hooks, two
query keys, and two raw type converters. Consolidates into a single
command returning the full catalog, with a useAvailableAcpProviders
hook that type-narrows for callers needing non-null command/binaryPath.

Also fixes: pipe deadlock in install command (#1), UTF-8 truncation
panic (#2/#4), adds install concurrency guard (#11), exact provider ID
match (#15), error display stdout fallback (#5), success banner
suppression when already available (#12), misleading re-run text (#13),
IIFE refactor in PersonaDialog (#14), hidden internal query lift (#7),
configurable e2e mocks (#9), shared raw type exports (#8), and
classify_provider unit tests (#10).
wpfleger96 added a commit that referenced this pull request May 22, 2026
@wpfleger96
refactor(desktop): consolidate ACP provider discovery and address rev…
3b26a0d 
…iew findings

The original implementation created a second parallel Tauri command
(discover_all_acp_providers) alongside the existing one to avoid
changing the return type. This produced two commands, two hooks, two
query keys, and two raw type converters. Consolidates into a single
command returning the full catalog, with a useAvailableAcpProviders
hook that type-narrows for callers needing non-null command/binaryPath.

Also fixes: pipe deadlock in install command (#1), UTF-8 truncation
panic (#2/#4), adds install concurrency guard (#11), exact provider ID
match (#15), error display stdout fallback (#5), success banner
suppression when already available (#12), misleading re-run text (#13),
IIFE refactor in PersonaDialog (#14), hidden internal query lift (#7),
configurable e2e mocks (#9), shared raw type exports (#8), and
classify_provider unit tests (#10).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesbillman