Rename namespaces for existing Python-based Bonsai.ML packages
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncguilbeault
force-pushed
the
dev/package-renaming-for-consistency
branch
from
5b1d76b to
7af31c2
Compare
ncguilbeault
force-pushed
the
dev/package-renaming-for-consistency
branch
from
7af31c2 to
660a8e7
Compare
glopesdev
reviewed
Oct 24, 2025
Member
glopesdev
left a comment
glopesdev
left a comment
There was a problem hiding this comment.
Looks good to me, should be okay to merge after resolving the failing tests on Windows (see below).
tests/Bonsai.ML.Lds.Python.Tests/ReceptiveFieldSimpleCellTest.cs
Outdated
Show resolved
Hide resolved
ncguilbeault
force-pushed
the
dev/package-renaming-for-consistency
branch
from
cc2b816 to
49bc1b2
Compare
glopesdev
approved these changes
Nov 7, 2025
glopesdev
changed the title
Bonsai.ML packagesBonsai.ML packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing Python-based Bonsai.ML packages, namely
Bonsai.ML.LinearDynamicalSystemsandBonsai.ML.HiddenMarkovModelspackages (and associated.Designand.Testspackages), to use a new naming convention. These changes ensure that going forward, we can maintain consistency across the project for implementing similar types of models using different backends (.Pythonversus.Torchfor example).