Skip to content

Bootstrap V4 Alpha checkbox fixes#302

Closed
trammel wants to merge 7 commits intobootstrap-ruby:masterfrom
trammel:v4-checkbox-fixes
Closed

Bootstrap V4 Alpha checkbox fixes#302
trammel wants to merge 7 commits intobootstrap-ruby:masterfrom
trammel:v4-checkbox-fixes

Conversation

@trammel
Copy link
Copy Markdown

@trammel trammel commented Oct 28, 2016

This is based on #299 and adds support for the changed class names for checkboxes in Bootstrap v4 alpha.

It also relates to #268 but, I don't see how it'll be possible to easily support Bootstrap v3 & v4 in the same version of the gem.

@bgentry
Copy link
Copy Markdown

bgentry commented Dec 6, 2016

Perhaps it would make sense to merge this into a v4-alpha working branch on this repo? Then others could continue submitting fixes for v4 up until its non-beta release.

Edit: I see there's a bootstrap-v4 branch but nothing has been pushed to it. Maybe just change this PR to merge there, and then merge if it's ok?

@desheikh
Copy link
Copy Markdown
Collaborator

@trammel @antpaw looks like we ended up duplicating this work. It doesn't look like there's anything new against the bootstrap-v4 branch, Can we close this?

@GBH
Copy link
Copy Markdown
Contributor

GBH commented Jan 7, 2018

This PR should be closed as it doesn't work with Bootstrap4 beta3. has_danger is not a thing and form group doesn't have class to indicate errors anymore.

@mattbrictson
Copy link
Copy Markdown
Contributor

@trammel I'm closing this PR for now, but I'd appreciate your help if you are still interested. Refer to #361 to see where are currently are on the Bootstrap v4 roadmap. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants