Tests for radio_button and checkbox with custom id#343
Closed
lcreid wants to merge 2 commits intobootstrap-ruby:masterfrom
Closed
Tests for radio_button and checkbox with custom id#343lcreid wants to merge 2 commits intobootstrap-ruby:masterfrom
radio_button and checkbox with custom id#343lcreid wants to merge 2 commits intobootstrap-ruby:masterfrom
Conversation
Contributor
Author
|
I originally submitted this to record an issue I didn't have time to address. Other people have found and fixed this issue, e.g. #357, so closing this PR. |
lcreid
pushed a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jun 4, 2018
If provided, use option `id` to specify `for` attribute on label for (text, email...) fields, checkbox, radio and select. Solves bootstrap-ruby#342 issue and supercede bootstrap-ruby#221 and bootstrap-ruby#343 pull requests. Partially solves bootstrap-ruby#251 (only the part regarding the id).
lcreid
added a commit
that referenced
this pull request
Mar 1, 2019
* Use option[:id] for label's *for* attribute If provided, use option `id` to specify `for` attribute on label for (text, email...) fields, checkbox, radio and select. Solves #342 issue and supercede #221 and #343 pull requests. Partially solves #251 (only the part regarding the id). * Move require mocha/minitest as needed by newer version. * Fix version of sqlite3 < 1.4 so tests will work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains test cases for
radio_buttonandcheckboxwith custom id, for issue #342. It doesn't include a fix. Waiting to see whether we want to fix this.