Skip to content

Backport the id change to the legacy branch.#525

Merged
lcreid merged 3 commits intolegacy-2.7from
legacy-id
Mar 1, 2019
Merged

Backport the id change to the legacy branch.#525
lcreid merged 3 commits intolegacy-2.7from
legacy-id

Conversation

@lcreid
Copy link
Copy Markdown
Contributor

@lcreid lcreid commented Mar 1, 2019

Port the fix for #357 to the legacy 2.7 branch for Bootstrap 3 users.

This replaces PR #507, and fixes the Travis build issues due to newer gem versions breaking the build.

Thanks very much to @pinkahd for the original PR!

duleorlovic and others added 3 commits January 25, 2019 13:05
@duleorlovic @pinkahd
Use option[:id] for label's *for* attribute
a6da2d7 
If provided, use option `id` to specify `for` attribute on label
for (text, email...) fields, checkbox, radio and select.
Solves #342 issue and supercede #221 and #343 pull requests.

Partially solves #251 (only the part regarding the id).
@lcreid
Move require mocha/minitest as needed by newer version.
321cabf
@lcreid
Fix version of sqlite3 < 1.4 so tests will work.
d27b865
@lcreid lcreid mentioned this pull request Mar 1, 2019
Closed
@bootstrap-ruby-bot
Copy link
Copy Markdown

bootstrap-ruby-bot commented Mar 1, 2019

1 Warning
⚠️ Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here! line):

* [#525](https://github.com/bootstrap-ruby/bootstrap_form/pull/525): Backport the id change to the legacy branch. - [@lcreid](https://github.com/lcreid).

Generated by 🚫 Danger

@lcreid lcreid merged commit 32206eb into legacy-2.7 Mar 1, 2019
@lcreid lcreid deleted the legacy-id branch March 1, 2019 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcreid @bootstrap-ruby-bot @duleorlovic