Use option[:id] for label's *for* attribute#507
Closed
pinkahd wants to merge 1 commit intobootstrap-ruby:legacy-2.7from
mubi:legacy-2.7
Closed
Use option[:id] for label's *for* attribute#507pinkahd wants to merge 1 commit intobootstrap-ruby:legacy-2.7from mubi:legacy-2.7
pinkahd wants to merge 1 commit intobootstrap-ruby:legacy-2.7from
mubi:legacy-2.7
Conversation
Here's an example of a CHANGELOG.md entry (place it immediately under the * [#507](https://github.com/bootstrap-ruby/bootstrap_form/pull/507): Use option[:id] for label's *for* attribute - [@pinkahd](https://github.com/pinkahd).Generated by 🚫 Danger |
Contributor
|
Sorry for the delay in responding. I'd be happy to merge this PR. I'm wondering if you know why we get the error about mocha methods in the Travis tests for Rails 4.2+? I'd feel better if we fix the test failures, because I suspect a lot of people still depend on this branch to work. I don't expect that your change will have broken anything, but it's happened to me lots of times. If you don't feel comfortable trying to fix the test failures, just let me know and I'll try to make time to see what I can do. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if you still accept fixed for
legacy-2.7branch.But I've ported the fix #357 for support
id's on labels for thelegacy version of the gem.
Original PR message