Skip to content

Use option[:id] for label's *for* attribute#507

Closed
pinkahd wants to merge 1 commit intobootstrap-ruby:legacy-2.7from
mubi:legacy-2.7
Closed

Use option[:id] for label's *for* attribute#507
pinkahd wants to merge 1 commit intobootstrap-ruby:legacy-2.7from
mubi:legacy-2.7

Conversation

@pinkahd
Copy link
Copy Markdown

@pinkahd pinkahd commented Jan 25, 2019

Don't know if you still accept fixed for legacy-2.7 branch.
But I've ported the fix #357 for support id's on labels for the
legacy version of the gem.

Original PR message

If provided, use option `id` to specify `for` attribute on label
for (text, email...) fields, checkbox, radio and select.
Solves #342 issue and supercede #221 and #343 pull requests.

Partially solves #251 (only the part regarding the id).

If provided, use option `id` to specify `for` attribute on label
for (text, email...) fields, checkbox, radio and select.
Solves #342 issue and supercede #221 and #343 pull requests.

Partially solves #251 (only the part regarding the id).
@bootstrap-ruby-bot
Copy link
Copy Markdown

1 Warning
⚠️ Please update CHANGELOG.md with a description of your changes. If this PR is not a user-facing change (e.g. just refactoring), you can disregard this.

Here's an example of a CHANGELOG.md entry (place it immediately under the * Your contribution here! line):

* [#507](https://github.com/bootstrap-ruby/bootstrap_form/pull/507): Use option[:id] for label's *for* attribute - [@pinkahd](https://github.com/pinkahd).

Generated by 🚫 Danger

@lcreid
Copy link
Copy Markdown
Contributor

lcreid commented Feb 6, 2019

Sorry for the delay in responding. I'd be happy to merge this PR. I'm wondering if you know why we get the error about mocha methods in the Travis tests for Rails 4.2+? I'd feel better if we fix the test failures, because I suspect a lot of people still depend on this branch to work. I don't expect that your change will have broken anything, but it's happened to me lots of times.

If you don't feel comfortable trying to fix the test failures, just let me know and I'll try to make time to see what I can do.

@lcreid
Copy link
Copy Markdown
Contributor

lcreid commented Mar 1, 2019

Not knowing how else to do it, I created a new PR #525 to fix the build problems.

@pinkahd Thanks very much for the original PR!

@lcreid lcreid closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants