Increment version to 4.0.0.dev and clean up gemspec, etc.#363
Increment version to 4.0.0.dev and clean up gemspec, etc.#363mattbrictson merged 5 commits intomasterfrom
Conversation
* Based on latest `bundle gem` template * Alphabetize dependencies * Add license * Homepage http -> https
Here's an example of a CHANGELOG.md entry (place it immediately under the * [#363](https://github.com/bootstrap-ruby/rails-bootstrap-forms/pull/363): Increment version to 4.0.0.dev and clean up gemspec, etc. - [@mattbrictson](https://github.com/mattbrictson).Generated by 🚫 Danger |
|
|
||
| s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] | ||
| s.test_files = Dir["test/**/*"] | ||
| s.files = `git ls-files -z`.split("\x0").reject do |f| |
There was a problem hiding this comment.
I like the idea of automating the generation of the file list. This looks to me like it will include in the gem some of the files that I would think of as development files, like .gitignore and .travis.yml. I don't think it's a problem, but I'm wondering there's a reason to include these files.
There was a problem hiding this comment.
It does include some unnecessary stuff, but I like that it is automatic so that we are less likely to forgot to add a file in the future. It is a standard suggested by Bundler, so I feel it is safe to follow:
lcreid
left a comment
lcreid
left a comment
There was a problem hiding this comment.
Looks good. I hope it's not stepping outside my scope to mark this as "Approved".
And thanks for asking us to review. For me, it's a good exercise of my Github skills (or lack thereof).
|
I appreciate the approval ✅ . That's exactly the process I'd like for us to follow, thanks! |
3 participants
bundle gemtemplate