Skip to content

Increment version to 4.0.0.dev and clean up gemspec, etc. #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattbrictson merged 5 commits into from
Jan 7, 2018
+19 −15
Merged

Increment version to 4.0.0.dev and clean up gemspec, etc. #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee3b263
Increment version to 4.0.0.dev
mattbrictson Jan 6, 2018
2e77274
Clarify in gemspec that we target Bootstrap v4
mattbrictson Jan 6, 2018
7b7cf60
Clean up gemspec
mattbrictson Jan 6, 2018
3d4ba3d
Move license to well-known location
mattbrictson Jan 6, 2018
910f24b
Happy new year! 🎊
mattbrictson Jan 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MIT-LICENSE → LICENSE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright 2012-2014 Stephen Potenza <potenza@gmail.com>
Copyright 2012-2018 Stephen Potenza <potenza@gmail.com>

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
Expand Down
30 changes: 17 additions & 13 deletions bootstrap_form.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
$:.push File.expand_path("../lib", __FILE__)

# Maintain your gem's version:
lib = File.expand_path("../lib", __FILE__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require "bootstrap_form/version"

# Describe your gem and declare its dependencies:
Expand All @@ -9,20 +8,25 @@ Gem::Specification.new do |s|
s.version = BootstrapForm::VERSION
s.authors = ["Stephen Potenza", "Carlos Lopes"]
s.email = ["potenza@gmail.com", "carlos.el.lopes@gmail.com"]
s.homepage = "http://github.com/bootstrap-ruby/rails-bootstrap-forms"
s.summary = "Rails form builder that makes it easy to style forms using Twitter Bootstrap 3+"
s.description = "bootstrap_form is a rails form builder that makes it super easy to create beautiful-looking forms using Twitter Bootstrap 3+"
s.homepage = "https://github.com/bootstrap-ruby/rails-bootstrap-forms"
s.summary = "Rails form builder that makes it easy to style forms using "\
"Bootstrap 4"
s.description = "bootstrap_form is a rails form builder that makes it super "\
"easy to create beautiful-looking forms using Bootstrap 4"
s.license = "MIT"

s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"]
s.test_files = Dir["test/**/*"]
s.files = `git ls-files -z`.split("\x0").reject do |f|
Copy link
Copy Markdown
Contributor

@lcreid lcreid Jan 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of automating the generation of the file list. This looks to me like it will include in the gem some of the files that I would think of as development files, like .gitignore and .travis.yml. I don't think it's a problem, but I'm wondering there's a reason to include these files.

Copy link
Copy Markdown
Contributor Author

@mattbrictson mattbrictson Jan 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does include some unnecessary stuff, but I like that it is automatic so that we are less likely to forgot to add a file in the future. It is a standard suggested by Bundler, so I feel it is safe to follow:

https://github.com/bundler/bundler/blob/fa7e4640c06d6c7d9e7c99480342f34008aa05fd/lib/bundler/templates/newgem/newgem.gemspec.tt#L31-L33

f.match(%r{^(test|spec|features)/})
end
s.bindir = "exe"

s.add_development_dependency "appraisal"
s.add_development_dependency "diffy"
s.add_development_dependency "equivalent-xml"
s.add_development_dependency "mime-types", "~> 2.6.2"
s.add_development_dependency "mocha"
s.add_development_dependency "nokogiri"
s.add_development_dependency "rails", ">= 4.0"
s.add_development_dependency "sqlite3"
s.add_development_dependency "timecop", "~> 0.7.1"
s.add_development_dependency "mocha"
s.add_development_dependency "appraisal"
s.add_development_dependency "equivalent-xml"
s.add_development_dependency "nokogiri"
s.add_development_dependency "diffy"
end
2 changes: 1 addition & 1 deletion lib/bootstrap_form/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module BootstrapForm
VERSION = "2.7.0".freeze
VERSION = "4.0.0.dev".freeze
end