fix: remove duplicate permission + add mktree to cspell#1005
Merged
tamirdresher merged 7 commits intodevfrom Apr 20, 2026
Merged
fix: remove duplicate permission + add mktree to cspell#1005tamirdresher merged 7 commits intodevfrom
tamirdresher merged 7 commits intodevfrom
Conversation
- Remove duplicate 'pull-requests: read' in squad-ci.yml that caused YAML parsing failure (0 jobs, instant CI failure) - Add 'mktree' to cspell.json dictionary (git command used in state-backends.md was flagged as unknown word) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CI failures on dev by correcting an invalid GitHub Actions workflow permissions block and updating the cspell dictionary to recognize a git command used in docs.
Changes:
- Removed a duplicate
pull-requests: readentry from.github/workflows/squad-ci.ymlso the workflow YAML parses and runs. - Added
mktreetocspell.jsonto prevent docs-quality spellcheck failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cspell.json |
Adds mktree to the dictionary to stop cspell from failing on the docs term. |
.github/workflows/squad-ci.yml |
Removes duplicate permissions key to restore valid workflow YAML parsing/execution. |
architectural-review.test.ts and check-bootstrap-deps.test.ts were left behind when PR #940 deleted the scripts they test (architectural-review.mjs, check-bootstrap-deps.mjs). Tests fail with 'No JSON object found' because the scripts no longer exist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…hanges - init.test.ts, upgrade.test.ts: use os.tmpdir() instead of process.cwd() for TEST_ROOT so temp dirs aren't inside the repo checkout, avoiding detectParentGitRepo() redirecting agent files to the repo root (8449a77) - loop.test.ts: update regex from /gh CLI/i to /Copilot CLI/i to match the new error message text (21587fb) - comms-teams-integration.test.ts: update expected warning to include authError detail in permanently-failed message Also fixes template-sync.test.ts indirectly — init tests were overwriting the repo's .github/agents/squad.agent.md causing a content mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Same monorepo detection fix as init/upgrade — tests creating temp dirs inside the repo checkout cause detectParentGitRepo() to write to .github/agents/ instead of the test dir, corrupting template-sync. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Same monorepo detection fix as other test files — place temp dir outside git repo to prevent detectParentGitRepo() from corrupting .github/agents/squad.agent.md during tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Acceptance tests run 'squad init' from the repo root, which overwrites .github/agents/squad.agent.md with CLI template content + version stamp. Since Vitest runs test files in parallel, this corrupts the file before template-sync checks it. Add beforeAll() that re-runs sync-templates.mjs to restore the canonical state before any byte-for-byte comparisons. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Same pattern as init, upgrade, export-import, scrub-emails, and init-upgrade-parity tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher
added a commit
that referenced
this pull request
Apr 21, 2026
Fixes all test failures on dev caused by monorepo subfolder detection (#939). Changes: - Use os.tmpdir() for test temp dirs to avoid detectParentGitRepo() interference - Update loop.test.ts regex from /gh CLI/i to /Copilot CLI/i (rebranding) - Update comms-teams warning message expectation (invalid_grant detail) - Remove orphaned test files for deleted scripts - Re-sync templates before byte comparison in template-sync test - Use tmpdir() in consult, init-upgrade-parity, export-import, scrub-emails tests All 6 CI jobs pass: changes, docs-quality, sdk-exports-validation, samples-build, test, Policy Gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes CI — all 213 tests green again 🟢
Root Causes (layered)
Changes
Testing
CI green — all 213 test files pass ✅