Skip to content

ci: remove fork-added workflows not in ralph/test/publish#940

Merged
bradygaster merged 3 commits intobradygaster:devfrom
diberry:squad/remove-fork-ci-workflows
Apr 11, 2026
Merged

ci: remove fork-added workflows not in ralph/test/publish#940
bradygaster merged 3 commits intobradygaster:devfrom
diberry:squad/remove-fork-ci-workflows

Conversation

@diberry
Copy link
Copy Markdown
Collaborator

@diberry diberry commented Apr 9, 2026

Remove 6 workflows added to the fork that don't fall into the core categories (ralph, test, publish), plus their orphaned scripts, tests, and doc references.

Workflows removed (6)

  • squad-docs-links.yml — weekly broken link checker
  • squad-impact.yml — PR impact analysis
  • squad-repo-health.yml — multi-check repo health
  • squad-scope-check.yml — scope boundary enforcement
  • squad-pr-nudge.yml — stale PR nudges
  • squad-pr-readiness.yml — PR readiness checks

Orphaned scripts removed (7 files)

  • scripts/pr-readiness.mjs, repo-health-comment.mjs, analyze-impact.mjs
  • scripts/impact-utils/ (parse-diff.mjs, report-generator.mjs, risk-scorer.mjs)

Orphaned tests removed (3 files)

  • test/pr-readiness.test.ts
  • test/scripts/parse-diff.test.ts, risk-scorer.test.ts

Docs updated (2 files)

  • .github/copilot-instructions.md — removed PR Nudge section
  • .copilot/skills/pr-lifecycle/SKILL.md — removed workflow references

Total: 3,193 lines deleted across 17 files

Copilot AI added 2 commits April 8, 2026 18:37
Remove 6 workflows added to the fork that don't fall into the
core categories (ralph, test, publish):
- squad-docs-links.yml (weekly link checker)
- squad-impact.yml (PR impact analysis)
- squad-repo-health.yml (multi-check repo health)
- squad-scope-check.yml (scope boundary enforcement)
- squad-pr-nudge.yml (stale PR nudges)
- squad-pr-readiness.yml (PR readiness checks)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove scripts and tests that were only used by the 6 removed workflows:
- scripts/pr-readiness.mjs, repo-health-comment.mjs, analyze-impact.mjs
- scripts/impact-utils/ directory
- test/pr-readiness.test.ts, test/scripts/parse-diff.test.ts, test/scripts/risk-scorer.test.ts
- Update copilot-instructions.md and pr-lifecycle SKILL.md to remove refs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 9, 2026 01:59
@diberry
Copy link
Copy Markdown
Collaborator Author

diberry commented Apr 9, 2026

Remaining CI workflows (14)

🔄 Ralph (5)

File Trigger Fires on PR?
squad-heartbeat.yml issues (closed/labeled), pull_request, workflow_dispatch ✅ Yes
squad-issue-assign.yml issues (labeled with squad:*) ❌ Issues only
squad-label-enforce.yml issues (labeled) ❌ Issues only
squad-triage.yml issues (labeled with squad) ❌ Issues only
sync-squad-labels.yml push, workflow_dispatch ✅ Yes (push after merge)

🧪 Test (2)

File Trigger Fires on PR?
squad-ci.yml pull_request, push ✅ Yes
ci-rerun.yml workflow_dispatch ❌ Manual only

🚢 Publish (4)

File Trigger Fires on PR?
squad-insider-publish.yml push (insider branch) ❌ Branch-specific
squad-insider-release.yml push (insider branch) ❌ Branch-specific
squad-npm-publish.yml workflow_dispatch ❌ Manual only
squad-release.yml push (main/tags) ❌ Main/tags only

📦 Other (upstream, kept) (3)

File Trigger Fires on PR?
squad-docs.yml push, workflow_dispatch ❌ Push only
squad-preview.yml push (preview branch) ❌ Branch-specific
squad-promote.yml workflow_dispatch ❌ Manual only

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a set of fork-added GitHub Actions workflows (and their supporting scripts/tests) so the repo only retains the core workflow set, with minor doc cleanups to drop references to removed automation.

Changes:

  • Deleted 6 GitHub Actions workflows (PR readiness, repo health, impact analysis, scope check, PR nudge, docs link check).
  • Removed associated Node scripts and impact utilities plus their Vitest coverage.
  • Updated Copilot instructions/skills docs to reduce references to removed workflows (needs follow-up for completeness).

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/scripts/risk-scorer.test.ts Deletes tests for removed impact risk scoring utility.
test/scripts/parse-diff.test.ts Deletes tests for removed diff parsing utility.
test/pr-readiness.test.ts Deletes tests for removed PR readiness script.
scripts/repo-health-comment.mjs Deletes comment upsert utility used by removed repo-health workflow.
scripts/pr-readiness.mjs Deletes PR readiness checker/orchestrator script.
scripts/impact-utils/risk-scorer.mjs Deletes impact risk scoring utility.
scripts/impact-utils/report-generator.mjs Deletes impact report markdown generator.
scripts/impact-utils/parse-diff.mjs Deletes impact diff parsing utility.
scripts/analyze-impact.mjs Deletes CLI-based PR impact analysis script.
.github/workflows/squad-scope-check.yml Deletes repo-health scope boundary enforcement workflow.
.github/workflows/squad-repo-health.yml Deletes repo-health workflow and its comment-posting steps.
.github/workflows/squad-pr-readiness.yml Deletes PR readiness workflow that posted checklist comments.
.github/workflows/squad-pr-nudge.yml Deletes scheduled stale-PR nudge workflow.
.github/workflows/squad-impact.yml Deletes PR impact analysis workflow.
.github/workflows/squad-docs-links.yml Deletes docs link-check workflow.
.github/copilot-instructions.md Removes PR Nudge section from Copilot instructions.
.copilot/skills/pr-lifecycle/SKILL.md Adjusts “source” metadata and references, but still contains now-stale readiness-bot content (see comment).
Comments suppressed due to low confidence (1)

.copilot/skills/pr-lifecycle/SKILL.md:428

  • This skill doc still describes an automated PR readiness bot and repeatedly references pr-readiness.mjs / readiness checks as “implemented”, but this PR deletes scripts/pr-readiness.mjs and .github/workflows/squad-pr-readiness.yml. Please revise this section (and any other parts of this doc that assume those checks exist) so guidance matches the repo after these workflow/script removals. Also consider updating other docs that currently claim “the PR readiness bot will validate these automatically” (e.g. PR template / CONTRIBUTING) as part of the same cleanup.
## Readiness Check Gaps & Recommendations

After analyzing `.github/workflows/squad-ci.yml`, three gaps were identified. Gaps 1 and 3 are now implemented (checks 10 and 11). Gap 2 is deferred.

### Gap 1: Issue Linkage Check (Check 10) — IMPLEMENTED

**Problem:** Nothing verifies that the PR body or commit message references an issue (`Closes #N` or `Part of #N`). Orphan PRs are hard to trace.

**Recommendation:** Add `checkIssueLinkage(prBody, commitMessages)` to `pr-readiness.mjs`.

@diberry diberry closed this Apr 10, 2026
@diberry diberry reopened this Apr 10, 2026
Copy link
Copy Markdown
Owner

@bradygaster bradygaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reducing this!

- Add repo-health scope boundary check to squad-ci.yml (replaces removed squad-scope-check.yml)
- Remove 4 orphaned scripts no longer called by any workflow:
  check-bootstrap-deps.mjs, check-squad-leakage.mjs,
  architectural-review.mjs, security-review.mjs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster merged commit 05e51e9 into bradygaster:dev Apr 11, 2026
tamirdresher pushed a commit that referenced this pull request Apr 18, 2026
architectural-review.test.ts and check-bootstrap-deps.test.ts were left
behind when PR #940 deleted the scripts they test (architectural-review.mjs,
check-bootstrap-deps.mjs). Tests fail with 'No JSON object found' because
the scripts no longer exist.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher pushed a commit that referenced this pull request Apr 21, 2026
* ci: remove fork-added workflows not in ralph/test/publish categories

Remove 6 workflows added to the fork that don't fall into the
core categories (ralph, test, publish):
- squad-docs-links.yml (weekly link checker)
- squad-impact.yml (PR impact analysis)
- squad-repo-health.yml (multi-check repo health)
- squad-scope-check.yml (scope boundary enforcement)
- squad-pr-nudge.yml (stale PR nudges)
- squad-pr-readiness.yml (PR readiness checks)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: remove orphaned scripts, tests, and doc refs from workflow cleanup

Remove scripts and tests that were only used by the 6 removed workflows:
- scripts/pr-readiness.mjs, repo-health-comment.mjs, analyze-impact.mjs
- scripts/impact-utils/ directory
- test/pr-readiness.test.ts, test/scripts/parse-diff.test.ts, test/scripts/risk-scorer.test.ts
- Update copilot-instructions.md and pr-lifecycle SKILL.md to remove refs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ci: add scope check to squad-ci.yml + remove orphaned scripts

- Add repo-health scope boundary check to squad-ci.yml (replaces removed squad-scope-check.yml)
- Remove 4 orphaned scripts no longer called by any workflow:
  check-bootstrap-deps.mjs, check-squad-leakage.mjs,
  architectural-review.mjs, security-review.mjs

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: brady gaster <brady.gaster@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants