Skip to content

fix: wire aspire CLI, export doctor, opt-in workflows, auto-gitignore config.json#233

Merged
bradygaster merged 4 commits intodevfrom
squad/phase3-cli-config
Mar 7, 2026
Merged

fix: wire aspire CLI, export doctor, opt-in workflows, auto-gitignore config.json#233
bradygaster merged 4 commits intodevfrom
squad/phase3-cli-config

Conversation

@bradygaster
Copy link
Copy Markdown
Owner

Working as Fenster (Core Dev)

Summary

Four surgical bug fixes in a single branch:

#226 — \squad aspire\ not wired into CLI

Added routing block and help text for the aspire command in \cli-entry.ts. The \�spire.ts\ implementation (175 lines) existed but was never connected to the command router. Now supports --docker\ and --port\ flags.

#229 — \squad doctor\ not available to SDK consumers

The CLI routing was already in place (lines 318-322), but
unDoctor, \doctorCommand, and related types were not exported from the CLI barrel (\cli/index.ts). Added exports so SDK consumers and downstream tooling can call doctor programmatically. Will ship in next npm release.

#201 — GitHub workflows should be opt-in

The \FRAMEWORK_WORKFLOWS\ filter was already limiting init to 4 safe framework workflows. Added a --no-workflows\ flag to \squad init\ so users can skip workflow installation entirely. The \RunInitOptions\ interface now accepts \includeWorkflows.

#202 — \config.json\ not auto-added to .gitignore\

Both \squad link\ and \squad init --mode remote\ now auto-append .squad/config.json\ to .gitignore\ after writing the config file, following the same pattern used for orchestration-log and sessions.

Test Results

All relevant tests pass (74/74 CLI tests). Pre-existing failures in consult/repl-ux E2E tests are unrelated and identical on \dev.

Closes #226, closes #229, closes #201, closes #202

bradygaster added a commit that referenced this pull request Mar 7, 2026
process.env.NODE_NO_WARNINGS only takes effect when set before the Node
process starts. When cli-entry.ts sets it at runtime, the warning still
fires during \�wait import('node:sqlite')\ and leaks into terminal
output. This caused 4 CI failures in --version tests that assert exactly
one line of output (bare semver).

Add a process.emit override that filters ExperimentalWarning events
before they reach stderr. Placed after the env var (which still helps
child processes) and before the sqlite pre-flight import.

Fixes CI for PR #233.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster added a commit that referenced this pull request Mar 7, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster and others added 4 commits March 6, 2026 20:53
… config.json

- Wire squad aspire command into CLI entry point with --docker/--port flags (#226)
- Export runDoctor/doctorCommand from CLI barrel for SDK consumers (#229)
- Add --no-workflows flag to squad init for opt-in workflow installation (#201)
- Auto-add .squad/config.json to .gitignore in link and init-remote (#202)

Closes #226, closes #229, closes #201, closes #202

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
process.env.NODE_NO_WARNINGS only takes effect when set before the Node
process starts. When cli-entry.ts sets it at runtime, the warning still
fires during \�wait import('node:sqlite')\ and leaks into terminal
output. This caused 4 CI failures in --version tests that assert exactly
one line of output (bare semver).

Add a process.emit override that filters ExperimentalWarning events
before they reach stderr. Placed after the env var (which still helps
child processes) and before the sqlite pre-flight import.

Fixes CI for PR #233.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster force-pushed the squad/phase3-cli-config branch from efb800f to 2f42e32 Compare March 7, 2026 04:53
@bradygaster bradygaster merged commit c086dbb into dev Mar 7, 2026
1 check passed
bradygaster added a commit that referenced this pull request Mar 7, 2026
…se wave done

Session: 2026-03-07T04-55-00Z-phase4-complete
Phase 4 Summary:
- Merged PR #235 (commit ce418c6): Test stabilization
- Merged PR #234 (commit f88bf4c): Runtime bug fixes
- Merged PR #233 (commit 2f42e32): CLI wiring + CI fix
- Closed 8 issues from PRs #234 and #233
- Test suite now at 100% pass rate (3,656 passing)
- CI fully green and stable
- Release wave v0.8.21 COMPLETE

Changes:
- Merged 4 decision inbox files into decisions.md
- Deleted 4 inbox files (now in shared decisions)
- 1 PR (#235) + 1 PR (#234) = 2 PRs already merged (Kobayashi phase 4)
- 1 PR (#233) rebased and merged by Coordinator
- All team state preserved via merge=union

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster added a commit that referenced this pull request Mar 7, 2026
* docs(ai-team): Phase 4 complete: 3 PRs merged, 8 issues closed, release wave done

Session: 2026-03-07T04-55-00Z-phase4-complete
Phase 4 Summary:
- Merged PR #235 (commit ce418c6): Test stabilization
- Merged PR #234 (commit f88bf4c): Runtime bug fixes
- Merged PR #233 (commit 2f42e32): CLI wiring + CI fix
- Closed 8 issues from PRs #234 and #233
- Test suite now at 100% pass rate (3,656 passing)
- CI fully green and stable
- Release wave v0.8.21 COMPLETE

Changes:
- Merged 4 decision inbox files into decisions.md
- Deleted 4 inbox files (now in shared decisions)
- 1 PR (#235) + 1 PR (#234) = 2 PRs already merged (Kobayashi phase 4)
- 1 PR (#233) rebased and merged by Coordinator
- All team state preserved via merge=union

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs(ai-team): Merge next-wave triage decisions, update agent history

Session: 2026-03-07-next-wave-triage
Requested by: Brady

Changes:
- Merged 3 inbox decisions (Keaton triage, Fenster PR review, Hockney test health)
- Updated agent history files with cross-team context propagation
- Deleted TRIAGE_REPORT.md from repo root (triage data belongs in .squad/)
- Orchestration logs written for all 3 agents
- Session log created for triage fan-out results
- Decision deduplication verified (no exact duplicates)

Decisions merged:
- Keaton: Full 22-issue triage, P0-P3 prioritization, v0.8.22 plan (11 issues)
- Fenster: 4 PR review, all retarget to dev, CLI wiring pattern adopted
- Hockney: Test suite health, 8 CLI commands untested, 30+ error-handling tests needed

Cross-agent context:
- Fenster: Notified of test gaps for CLI wiring work
- Edie: Notified of model config priority (#223 > #205)
- Rabin: Notified of migration wave grouping (#197/#231/#126) and ADO config blocker
- Keaton: Updated with triage scope and decisions
- Hockney: Updated with test infrastructure gaps for next-wave

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio pushed a commit to jongio/squad that referenced this pull request Mar 9, 2026
…adygaster#235)

* chore: add ink and react dependencies (bradygaster#233)

Adds production dependencies:
- ink@6.8.0 (React for CLIs)
- react@19.2.4

Adds dev dependencies:
- ink-testing-library@4.0.0
- @types/react@19.2.14

Closes bradygaster#233

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: shell module structure + main entry wiring (bradygaster#234, bradygaster#235)

Create src/cli/shell/ module with types, placeholder runShell(), and
wire squad (no args) to enter the interactive shell instead of running init.

- src/cli/shell/types.ts: ShellState, ShellMessage, AgentSession interfaces
- src/cli/shell/index.ts: placeholder runShell() with version header
- src/cli/shell/components/.gitkeep: placeholder for ink components
- src/index.ts: no-args routes to runShell(), 'init' is now explicit subcommand

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: update fenster history + decision inbox for shell module

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio pushed a commit to jongio/squad that referenced this pull request Mar 9, 2026
Adds production dependencies:
- ink@6.8.0 (React for CLIs)
- react@19.2.4

Adds dev dependencies:
- ink-testing-library@4.0.0
- @types/react@19.2.14

Closes bradygaster#233

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster deleted the squad/phase3-cli-config branch March 16, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant