Skip to content

fix: resolve 4 runtime bugs (#214, #207, #206, #193)#234

Merged
bradygaster merged 7 commits intodevfrom
squad/phase3-runtime
Mar 7, 2026
Merged

fix: resolve 4 runtime bugs (#214, #207, #206, #193)#234
bradygaster merged 7 commits intodevfrom
squad/phase3-runtime

Conversation

@bradygaster
Copy link
Copy Markdown
Owner

@bradygaster bradygaster commented Mar 7, 2026

Summary

Fixes 4 runtime bugs in a single branch. Working as Fenster (Core Dev).

#214 — node:sqlite builtin module error

The @github/copilot SDK lazily imports
ode:sqlite\ for session storage. On Node.js versions that lack this builtin (pre-22.5.0 or builds without experimental-sqlite), this caused an opaque \ERR_UNKNOWN_BUILTIN_MODULE\ crash. Added a pre-flight check in \cli-entry.ts\ that detects the missing module and surfaces a clear warning with upgrade instructions before the shell launches.

#207 — Squad not found from non-root directory

Fixed two path resolution bugs:

  • Nap command:
    esolveSquad()\ returns the .squad/\ directory path itself, but the nap handler re-joined it with .squad, producing .squad/.squad.
  • Consult mode exit: Hardcoded \process.cwd() + '.squad'\ instead of using the already-resolved \ eamRoot, failing when running from subdirectories.

#206 — Terminal blink/flicker during output

Reduced animation timer frequencies to cut Ink re-render rate:

  • Spinner: 80ms → 120ms
  • Pulsing dot: 300ms → 500ms
  • Elapsed timer: 200ms → 1000ms
  • Removed \x1b[3J\ (clear scrollback buffer) from startup screen clear, which was resetting the user's scroll position.

#193 — Ceremonies file breaks parsing when too large

Added size threshold handling to \squad build. When the generated \ceremonies.md\ would exceed 15KB (safely under the ~20KB tool-view limit), the build now emits:

  • A compact dispatch table as \ceremonies.md\ (~3-4KB even with 50+ ceremonies)
  • Individual ceremony skill files at .squad/skills/ceremony-{name}/SKILL.md\

Testing

  • TypeScript strict mode: 0 errors
  • 151 relevant tests pass (build, nap, resolution, shell-integration, builders)
  • Pre-existing test failures on \dev\ are unchanged

Closes #214, Closes #207, Closes #206, Closes #193

bradygaster and others added 7 commits March 5, 2026 14:49
@bradygaster
docs(ai-team): Azure Function sample fix + SDK-First blog post
29a65dc 
Session: 2026-03-05T22-46-00Z-azure-func-fix
Requested by: (internal spawning)

Changes:
- Logged Azure Function sample fix (Fenster: main field + build step)
- Logged sample verification (Hockney: build + dry-run pass)
- Merged fenster-azure-func-fix decision (Azure Functions v4 pattern)
- Merged mcmanus-release-blog decision (v0.8.21 SDK-First announcement)
- Propagated team updates to Fenster + Hockney history.md
- Deleted merged inbox files
@bradygaster
docs(squad): triage session — directives, orchestration log, session log
ea0bddb 
Session: 2026-03-06T15-37-00Z-full-triage
Requested by: Copilot (via user directive)

Changes:
- Merged 2 quality directives into decisions.md (quality-first, double-triple-check)
- Created orchestration logs for Keaton (lead), Fenster (CLI audit), Hockney (test analysis)
- Created session log documenting full triage session outcomes
- Deleted inbox directive files after merge

Summary:
Keaton completed comprehensive issue/PR triage (6-phase plan, PR assessments).
Fenster audited CLI command wiring (aspire missing, nap/remote/consult confirmed).
Hockney analyzed 44 test failures (7 themes, 7 minimum fixes resolve 80%).
Quality directives: locked-out policy + cross-verification requirement.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
Merge branch 'dev' of https://github.com/bradygaster/squad into dev
aeb66ab
@bradygaster
Merge branch 'dev' of https://github.com/bradygaster/squad into dev
35209c8
@bradygaster
docs(ai-team): Phase 2 release wave complete
28eabcf 
Session: 2026-03-07T01-13-00Z-phase2-complete
Requested by: Brady

Changes:
- Merged 3 inbox decisions (Kobayashi PR merges, Keaton community PRs, Fenster template fix)
- Logged orchestration results for all 3 agents (Kobayashi, Keaton, Hockney)
- Logged Phase 2 session completion
- Appended Phase 2 results to agent history files (cross-agent updates)
- Deduplicated: No duplicate decisions found; all 3 inbox items were new.

Merges completed:
- PR #232: Scribe runtime state fix (86598f4)
- PR #212: Version stamp preservation (0fedcce)
- PR #230: CLI wire-up squad link + squad init --mode remote (6d0bd56)
- PR #217: TUI /init no-args flow fix (20970f9)
- PR #219: Fork contribution workflow docs (157b8c0)

Test results: 130/134 test files passing. 12 pre-existing failures in consult, REPL, status, acceptance modes. Core CLI solid.
@bradygaster
docs(ai-team): History summarization — Core Context consolidation
814457f 
Session: 2026-03-07T01-13-00Z-history-summarization
Requested by: Scribe (auto)

Changes:
- Kobayashi history: Consolidated pre-Phase-1 entries into ## Core Context section (82.7 KB → 5.1 KB)
- Keaton history: Consolidated pre-Phase-1 entries into ## Core Context section (94 KB → 4.3 KB)
- Hockney history: Consolidated pre-Phase-1 entries into ## Core Context section (116.5 KB → 3.7 KB)

Core Context sections summarize:
- Project setup and foundational decisions (2026-02-21)
- Architecture decisions and design patterns (2026-02-21 to 2026-03-04)
- Wave planning and readiness assessments (2026-02-22 to 2026-03-05)
- Known issues and learning points

Recent learnings (Phase 1 and Phase 2) preserved in full detail for current relevance.
All files now under 12KB limit.
@bradygaster
fix: resolve 4 runtime bugs (#214, #207, #206, #193)
d564809 
- #214: Add pre-flight node:sqlite availability check before shell launch.
  The @github/copilot SDK lazily imports node:sqlite; surfaces a clear
  warning on Node.js builds that lack the builtin instead of crashing.

- #207: Fix squad directory resolution from non-root directories.
  Nap command double-joined .squad path (resolveSquad already returns
  the .squad dir). Consult mode exit check used hardcoded cwd instead
  of the resolved teamRoot.

- #206: Reduce terminal blink/flicker during squad output.
  Throttle animation intervals (spinner 80ms→120ms, pulse 300ms→500ms,
  elapsed 200ms→1000ms). Remove scrollback-clearing escape code from
  startup to prevent scroll position reset.

- #193: Add ceremonies file size handling to prevent parsing failures.
  When generated ceremonies.md exceeds 15KB threshold, splits into a
  compact dispatch table + individual ceremony skill files under
  .squad/skills/ceremony-{name}/SKILL.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster merged commit f88bf4c into dev Mar 7, 2026
1 check passed
This was referenced Mar 7, 2026
Closed
Closed
Closed
Closed
bradygaster added a commit that referenced this pull request Mar 7, 2026
@bradygaster
docs(ai-team): Phase 4 complete: 3 PRs merged, 8 issues closed, relea…
6e304ec 
…se wave done

Session: 2026-03-07T04-55-00Z-phase4-complete
Phase 4 Summary:
- Merged PR #235 (commit ce418c6): Test stabilization
- Merged PR #234 (commit f88bf4c): Runtime bug fixes
- Merged PR #233 (commit 2f42e32): CLI wiring + CI fix
- Closed 8 issues from PRs #234 and #233
- Test suite now at 100% pass rate (3,656 passing)
- CI fully green and stable
- Release wave v0.8.21 COMPLETE

Changes:
- Merged 4 decision inbox files into decisions.md
- Deleted 4 inbox files (now in shared decisions)
- 1 PR (#235) + 1 PR (#234) = 2 PRs already merged (Kobayashi phase 4)
- 1 PR (#233) rebased and merged by Coordinator
- All team state preserved via merge=union

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bradygaster added a commit that referenced this pull request Mar 7, 2026
@bradygaster
fix: wire missing CLI commands into cli-entry.ts (#244)
a488eb8 
* docs(ai-team): Phase 4 complete: 3 PRs merged, 8 issues closed, release wave done

Session: 2026-03-07T04-55-00Z-phase4-complete
Phase 4 Summary:
- Merged PR #235 (commit ce418c6): Test stabilization
- Merged PR #234 (commit f88bf4c): Runtime bug fixes
- Merged PR #233 (commit 2f42e32): CLI wiring + CI fix
- Closed 8 issues from PRs #234 and #233
- Test suite now at 100% pass rate (3,656 passing)
- CI fully green and stable
- Release wave v0.8.21 COMPLETE

Changes:
- Merged 4 decision inbox files into decisions.md
- Deleted 4 inbox files (now in shared decisions)
- 1 PR (#235) + 1 PR (#234) = 2 PRs already merged (Kobayashi phase 4)
- 1 PR (#233) rebased and merged by Coordinator
- All team state preserved via merge=union

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs(ai-team): Merge next-wave triage decisions, update agent history

Session: 2026-03-07-next-wave-triage
Requested by: Brady

Changes:
- Merged 3 inbox decisions (Keaton triage, Fenster PR review, Hockney test health)
- Updated agent history files with cross-team context propagation
- Deleted TRIAGE_REPORT.md from repo root (triage data belongs in .squad/)
- Orchestration logs written for all 3 agents
- Session log created for triage fan-out results
- Decision deduplication verified (no exact duplicates)

Decisions merged:
- Keaton: Full 22-issue triage, P0-P3 prioritization, v0.8.22 plan (11 issues)
- Fenster: 4 PR review, all retarget to dev, CLI wiring pattern adopted
- Hockney: Test suite health, 8 CLI commands untested, 30+ error-handling tests needed

Cross-agent context:
- Fenster: Notified of test gaps for CLI wiring work
- Edie: Notified of model config priority (#223 > #205)
- Rabin: Notified of migration wave grouping (#197/#231/#126) and ADO config blocker
- Keaton: Updated with triage scope and decisions
- Hockney: Updated with test infrastructure gaps for next-wave

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio pushed a commit to jongio/squad that referenced this pull request Mar 9, 2026
@bradygaster
feat: shell module structure + main entry wiring (bradygaster#234, br…
19d8473 
…adygaster#235)

* chore: add ink and react dependencies (bradygaster#233)

Adds production dependencies:
- ink@6.8.0 (React for CLIs)
- react@19.2.4

Adds dev dependencies:
- ink-testing-library@4.0.0
- @types/react@19.2.14

Closes bradygaster#233

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: shell module structure + main entry wiring (bradygaster#234, bradygaster#235)

Create src/cli/shell/ module with types, placeholder runShell(), and
wire squad (no args) to enter the interactive shell instead of running init.

- src/cli/shell/types.ts: ShellState, ShellMessage, AgentSession interfaces
- src/cli/shell/index.ts: placeholder runShell() with version header
- src/cli/shell/components/.gitkeep: placeholder for ink components
- src/index.ts: no-args routes to runShell(), 'init' is now explicit subcommand

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: update fenster history + decision inbox for shell module

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster deleted the squad/phase3-runtime branch March 16, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bradygaster