Skip to content

docs: consolidated docs quality, reduction, and dedup#389

Merged
bradygaster merged 13 commits intobradygaster:devfrom
diberry:squad/docs-reduction-refinement
Mar 15, 2026
Merged

docs: consolidated docs quality, reduction, and dedup#389
bradygaster merged 13 commits intobradygaster:devfrom
diberry:squad/docs-reduction-refinement

Conversation

@diberry
Copy link
Copy Markdown
Collaborator

@diberry diberry commented Mar 14, 2026

Consolidated docs quality & reduction PR

Merges 7 content PRs into one to simplify review. Addresses the full PAO docs audit (redundancy, bloat, dedup, gaps).

Closes #258, Fixes #351, Addresses #197 item 6, Addresses #398

What changed (19 files, -1,471 net lines)

Bloat reduction (Phase 1 complete)

File Before After Cut
guide.md 504 213 -58%
tips-and-tricks.md 641 320 -50%
sample-prompts.md 659 305 -54%
upstream-inheritance.md 533 288 -46%
release-process.md 437 246 -44%
sdk-first-mode.md 659 517 -22%
mcp.md 333 300 -10%
enterprise-platforms.md MCP dedup

Deduplication

New & updated pages

Team governance

Test updates

  • test/docs-build.test.ts: updated expected page count for new choose-your-interface page

Traceability — what was removed and where it lives

Removed content From Canonical location
Prompt patterns section tips-and-tricks.md Getting started guide
Memory system section tips-and-tricks.md Memory feature page
Getting started walkthrough guide.md Compressed; detail in feature pages
MCP setup duplication enterprise-platforms.md MCP page
Notification setup duplication enterprise-platforms.md, github-workflow.md Notifications
v0.2.0/v0.3.0 feature showcase (prompts 17-23) sample-prompts.md Tips and Tricks
Duplicate type definitions (8 builders) sdk-first-mode.md Common Types reference table (in-file)
SDK vs CLI comparison table sdk-first-mode.md Guide
Team init flow sdk-first-mode.md Guide
6 scenarios merged to 3 upstream-inheritance.md In-file consolidation
Duplicate branch model prose release-process.md Kept table, removed prose (in-file)
Verbose troubleshooting release-process.md Compressed to fix-only format (in-file)
Duplicate MCP definition mcp.md Single definition at top (in-file)
Redundant config examples mcp.md Template pattern (in-file)

Supersedes these PRs

@diberry
Copy link
Copy Markdown
Collaborator Author

diberry commented Mar 14, 2026

@bradygaster This is deduplication only

@diberry
Copy link
Copy Markdown
Collaborator Author

diberry commented Mar 15, 2026

✅ Full Team Review Complete — Ready for Merge

The entire squad reviewed PR #389 across 3 rounds and all reviewers now approve.

Review Summary

Reviewer Role Verdict
🏗️ Flight Lead / Architecture ✅ APPROVE — user journey coherent, no dead ends
📝 PAO DevRel / Content Quality ✅ APPROVE — all links validated, heading consistency verified
🧪 FIDO Quality Owner ✅ APPROVE — tests pass, file structure matches assertions

Issues Found & Fixed (3 rounds)

Round 1 (6 fixes):

  • guide.md: removed 2 unnecessary H1 anchors (#response-modes, #memory-system)
  • tips-and-tricks.md: same memory.md anchor fix
  • notifications.md: title case → sentence case heading
  • docs-build.test.ts: added 'migration' to EXPECTED_GET_STARTED
  • README.md: fixed sdk-first-mode.md path

Round 2 (2 fixes):

  • migration.md: broken SDK link sdk/../reference/sdk.md
  • sample-prompts.md: broken tips link /tips-and-trickstips-and-tricks.md

Round 3: Clean — zero issues found across all 9 changed docs files.

PR Scope

@bradygaster
Copy link
Copy Markdown
Owner

Hey @diberry — this PR now has merge conflicts after PR #404 (cross-platform filename/config fixes) landed on dev. Could you rebase against dev when you get a chance? The squad review is all ✅ and we're ready to merge as soon as the conflicts are resolved. 🚀

diberry and others added 13 commits March 15, 2026 07:27
…setup

- Shorten 8 guide.md sections to intro + link (detail lives on feature pages)
- Trim Ralph and Memory sections in tips-and-tricks.md
- Replace duplicated MCP config blocks with links to canonical mcp.md
- Replace duplicated notification setup with links to notifications.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- sample-prompts.md: 659->305 lines (-54%), removed feature showcase sections duplicating tips-and-tricks
- sdk-first-mode.md: 659->517 lines (-22%), consolidated type defs into reference table
- upstream-inheritance.md: 533->288 lines (-46%), merged 6 scenarios into 3
- release-process.md: 437->246 lines (-44%), compressed verbose prose to tables/bullets
- mcp.md: 333->300 lines (-10%), deduplicated MCP definition and config blocks

All copy-paste-ready content preserved. Cross-links added to canonical sources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds a hard rule requiring PAO to search for existing coverage before
writing new content, link to canonical pages instead of duplicating,
and flag duplication during reviews. Prevents unnecessary docs growth.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require anchor/fragment links when a more specific section exists,
rather than linking to just the page URL.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace duplicated 3-step flow, triggers table, and config reference
with a single cross-link to the canonical Notifications Guide.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…er#351

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add local (--save-dev) and npx alternatives alongside global install
- Update Node.js version requirement from 18 to 20 (matches package.json)
- Replace hardcoded @0.8.18 version pins with @latest

Closes bradygaster#197 (item 6 — docs scope only)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Removed broken reference to microsoft/IF-MCP-Server-for-Microsoft-Teams (it's actually a Court Listener demo, not a general Teams MCP server)
- Clarified that path/to/*.js placeholders require actual MCP server implementations
- Added link to community reference implementation (benleane83's teams-webhook-mcp.js gist)
- Updated all MCP config examples to use /absolute/path/to/ format for clarity
- Simplified Teams setup to focus on webhook approach (fastest, most practical)
- Updated iMessage MCP server link to point to marketplace search instead of specific (potentially dead) link

Closes bradygaster#258

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add 'Choose your interface' page covering all Squad interfaces
- Link from installation, guide, and client-compatibility pages
- Update docs test assertions for new page

Partial fix for bradygaster#398

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ion, README link

Fixes from team review (PAO + FIDO):
- guide.md: remove H1 anchors from response-modes and memory links
- tips-and-tricks.md: same memory.md anchor fix
- notifications.md: title case -> sentence case heading
- docs-build.test.ts: add migration to EXPECTED_GET_STARTED
- README.md: fix sdk-first-mode.md path

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- migration.md: sdk/ -> ../reference/sdk.md
- sample-prompts.md: /tips-and-tricks -> tips-and-tricks.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replaces bare 'copilot --yolo' with 'copilot --agent squad --yolo' to show
the recommended startup command with the agent flag. Simplifies the VS Code
instruction line.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adds a clear comparison of what gets compacted vs what persists
permanently in Squad's memory system. Helps users understand where
to store knowledge that must survive compaction cycles.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry diberry force-pushed the squad/docs-reduction-refinement branch from 78a5828 to 9cfb35a Compare March 15, 2026 14:29
@diberry
Copy link
Copy Markdown
Collaborator Author

diberry commented Mar 15, 2026

@bradygaster Ready for your review — docs reduction and refinement across 19 files. CI is green. — squad obo dina

@bradygaster bradygaster merged commit ccb9b53 into bradygaster:dev Mar 15, 2026
1 check passed
tamirdresher pushed a commit to tamirdresher/squad that referenced this pull request Mar 16, 2026
…radygaster#413)

* chore(squad): quality review findings — 7 issues filed

Quality audit complete: 5 agents assessed CLI across testing, coverage, stability, accessibility, UX.
Results: 4 P0 blockers (bradygaster#365bradygaster#368), 3 P1 items (bradygaster#369bradygaster#371).
Blocking: Waingro dead sessions, ErrorBoundary, dropped input; Marquez help text consistency.

Changes:
- Logged session summary to .squad/log/2026-02-24T0205-quality-review-complete.md
- Updated .squad/identity/now.md with quality review findings and new issue numbers

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore(squad): merge decision — Marquez UX audit findings

Quality assessment merged from inbox (Grade B): 11 improvements (3 P0, 4 P1, 4 P2). help text, stub commands, vocabulary, separators, roster.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: visual polish — separators, help, status, agents, thinking indicator

- Replace ASCII hyphens with box-drawing chars (U+2500) in AgentPanel
  and MessageStream separators for visual consistency
- Restructure /help with section headers, column alignment, shortcuts
- Redesign /status with brand mark and clean key-value layout
- Replace /agents bracket notation ([IDLE]) with emoji + status words
- Fix ThinkingIndicator double-dim making text nearly invisible
- Add 'quit' to bare-word exit (matches /quit behavior)
- Update tests to match new output format

Closes bradygaster#388, bradygaster#389, bradygaster#390, bradygaster#391, bradygaster#392, bradygaster#393

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: update Marquez history with visual polish session

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tamirdresher pushed a commit to tamirdresher/squad that referenced this pull request Mar 16, 2026
…x chars

Fixes bradygaster#400 - /clear now sends ANSI escape codes to actually clear terminal screen
Fixes bradygaster#389 - Recognize 'quit' and 'q' as exit words (not just 'exit')
Fixes bradygaster#417 - Root CLI detects .squad/ existence and auto-launches shell or suggests init
Fixes bradygaster#391 - Use proper Unicode box-drawing characters (─) with graceful ASCII fallback

Changes:
- commands.ts: Send \x1B[2J\x1B[H on /clear to truly clear the terminal
- App.tsx: Expand EXIT_WORDS to include 'quit' and 'q'
- cli-entry.ts: Check for .squad/ before defaulting to shell, show helpful init prompt if missing
- AgentPanel.tsx + MessageStream.tsx: Use boxChars() for separators instead of hardcoded '─'

All changes preserve cross-platform compatibility and respect NO_COLOR/terminal capabilities.

Co-authored-by: bradygaster <brady@github.com>
tamirdresher pushed a commit to tamirdresher/squad that referenced this pull request Mar 16, 2026
tamirdresher pushed a commit to tamirdresher/squad that referenced this pull request Mar 16, 2026
Session: 2026-02-24T0430-prs-merged
Requested by: Brady

Changes:
- Merged 6 decision inbox files into decisions.md (Cheritto, Fenster, Kovash, Marquez, McManus, Waingro)
- Deleted all inbox files (now empty)
- Created .squad/identity/prd-next-waves.md (4-wave execution plan: A=Polish, B=Reliability, C=Testing, D=Delight)
- Updated .squad/identity/now.md to reflect Wave A focus
- Created session log: .squad/log/2026-02-24T0430-prs-merged.md

PRs merged this session: bradygaster#444, bradygaster#445, bradygaster#446, bradygaster#447
Issues closed: bradygaster#400, bradygaster#389, bradygaster#417, bradygaster#391, bradygaster#402, bradygaster#405, bradygaster#404, bradygaster#407, bradygaster#431, bradygaster#429
Issues filed: bradygaster#448-bradygaster#459 (Wave A Polish items)

Process directive: All work through PRs with squad member review before merge

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants