Skip to content

docs: dedup notification setup in github-workflow.md#392

Closed
diberry wants to merge 1 commit intobradygaster:devfrom
diberry:squad/dedup-github-workflow-notifications
Closed

docs: dedup notification setup in github-workflow.md#392
diberry wants to merge 1 commit intobradygaster:devfrom
diberry:squad/dedup-github-workflow-notifications

Conversation

@diberry
Copy link
Copy Markdown
Collaborator

@diberry diberry commented Mar 14, 2026

Summary

Replaces duplicated notification content in concepts/github-workflow.md with a cross-link to the canonical Notifications Guide.

Change

docs/src/content/docs/concepts/github-workflow.md - 1 file, +1/-12 lines

Deduplication Traceability

Removed Content Was At Kept At (canonical)
3-step notification flow (Skill > Agent > MCP server) github-workflow.md lines 178-181 notifications.md - How It Works (rendered)
Triggers table (Blocked/Error/Complete) github-workflow.md lines 183-187 notifications.md - What Triggers a Notification (rendered)
Config file reference (mcp.json / mcp-config.json) github-workflow.md line 189 notifications.md - Quick Start: Teams (rendered)

What is Preserved

  • The intro sentence stays and gives context
  • Cross-link to the Notifications Guide covers: setup walkthrough, platform options, triggers, sample configs

Scope

Docs only. No code changes.

Replace duplicated 3-step flow, triggers table, and config reference
with a single cross-link to the canonical Notifications Guide.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@diberry diberry force-pushed the squad/dedup-github-workflow-notifications branch from 0fab0c4 to b0bf0df Compare March 14, 2026 17:21
@diberry
Copy link
Copy Markdown
Collaborator Author

diberry commented Mar 14, 2026

Consolidated into PR #389 — all changes from this PR have been merged into the consolidated docs quality PR.

@diberry diberry closed this Mar 14, 2026
bradygaster pushed a commit that referenced this pull request Mar 15, 2026
Merges diberry's consolidated docs PR #389.
Closes #258, Fixes #351, Addresses #197 item 6, Addresses #398.
19 files, -1,471 net lines. Bloat reduction across guide.md, tips-and-tricks.md, sample-prompts.md, and more.
Supersedes PRs #390, #391, #392, #395, #397, #399.
tamirdresher pushed a commit to tamirdresher/squad that referenced this pull request Mar 16, 2026
…radygaster#413)

* chore(squad): quality review findings — 7 issues filed

Quality audit complete: 5 agents assessed CLI across testing, coverage, stability, accessibility, UX.
Results: 4 P0 blockers (bradygaster#365bradygaster#368), 3 P1 items (bradygaster#369bradygaster#371).
Blocking: Waingro dead sessions, ErrorBoundary, dropped input; Marquez help text consistency.

Changes:
- Logged session summary to .squad/log/2026-02-24T0205-quality-review-complete.md
- Updated .squad/identity/now.md with quality review findings and new issue numbers

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* chore(squad): merge decision — Marquez UX audit findings

Quality assessment merged from inbox (Grade B): 11 improvements (3 P0, 4 P1, 4 P2). help text, stub commands, vocabulary, separators, roster.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: visual polish — separators, help, status, agents, thinking indicator

- Replace ASCII hyphens with box-drawing chars (U+2500) in AgentPanel
  and MessageStream separators for visual consistency
- Restructure /help with section headers, column alignment, shortcuts
- Redesign /status with brand mark and clean key-value layout
- Replace /agents bracket notation ([IDLE]) with emoji + status words
- Fix ThinkingIndicator double-dim making text nearly invisible
- Add 'quit' to bare-word exit (matches /quit behavior)
- Update tests to match new output format

Closes bradygaster#388, bradygaster#389, bradygaster#390, bradygaster#391, bradygaster#392, bradygaster#393

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* docs: update Marquez history with visual polish session

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant