fix: insider publish workflow - add build step and use Node 22#851
fix: insider publish workflow - add build step and use Node 22#851tamirdresher wants to merge 1 commit intodevfrom
Conversation
The insider publish workflow had two issues causing 80+ test failures: 1. The test job ran on a separate VM from the build job with no artifact transfer. Since dist/ is gitignored, the test job had no compiled output. Vitest failed to resolve workspace package exports (e.g. @bradygaster/squad-sdk entry, squad-cli/commands/rc) because the dist files they point to didn't exist. 2. All three jobs used Node 20, but both packages declare engines.node >= 22.5.0. The CLI's version gate rejected Node 20 at runtime, causing additional failures. Fix: Add 'npm run build' step to the test job, and update all jobs from node-version [20] to [22] to match the engines requirement and the main CI workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 17 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🏗️ Architectural Review
Automated architectural review — informational only. |
🟢 Impact Analysis — PR #851Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
This report is generated automatically for every PR. See #733 for details. |
There was a problem hiding this comment.
Pull request overview
Fixes the insider publish GitHub Actions workflow so tests run against compiled workspace outputs and the workflow runs on a Node.js version compatible with the repo’s declared engines.
Changes:
- Bumped all jobs in
squad-insider-publish.ymlfrom Node 20 to Node 22. - Added an explicit
npm run buildstep to thetestjob beforenpm test.
| - name: Build | ||
| run: npm run build | ||
|
|
There was a problem hiding this comment.
The test job now runs npm run build, but the separate build job already builds and does not publish artifacts. Since GitHub Actions jobs run on separate runners, this results in two independent builds with no reuse. Consider either (a) removing the standalone build job and dropping needs: build, or (b) uploading build outputs from build and downloading them in test to avoid redundant work.
|
Closing as stale. Reason: CI fix PR with merge conflicts and failures. The fixes have likely been applied via other PRs. |
Problem
The insider publish workflow (squad-insider-publish.yml) had 80+ test failures every run, blocking insider publishes.
Root Cause
Missing build step in test job: The build and test jobs run on separate VMs. Since dist/ is gitignored, the test job starts with a fresh checkout that has no compiled output. Vitest fails to resolve workspace package exports.
Wrong Node version: All jobs used node-version [20], but both packages declare engines.node >= 22.5.0. The CLI version gate rejects Node 20 at runtime.
Fix
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com