Skip to content

fix(ci): insider publish - Node 22, build step, and Playwright install#854

Merged
tamirdresher merged 1 commit intodevfrom
fix/insider-publish-playwright
Apr 5, 2026
Merged

fix(ci): insider publish - Node 22, build step, and Playwright install#854
tamirdresher merged 1 commit intodevfrom
fix/insider-publish-playwright

Conversation

@tamirdresher
Copy link
Copy Markdown
Collaborator

What

Proper fix for the insider publish workflow CI failures.

Changes

  • Node 20 → 22 across all jobs (build, test, publish) for actions/setup-node v4 compatibility
  • Build step in test job — tests require compiled output from
    pm run build\
  • Install Playwright Chromium via
    px playwright install chromium --with-deps\ so aspire-integration tests actually run
  • Exclude only docs-build test — it needs Docker which isn't available on the publish runner; all other tests (including Playwright) now run properly

Why

The insider publish workflow runs on a clean GitHub Actions runner. Without building first and installing Playwright, the test job fails. Previous PRs (#851, #852) worked around this by skipping Playwright tests entirely — this PR fixes the root cause so the tests validate properly.

Supersedes: #851, #852

- Upgrade all jobs from Node 20 to Node 22 (actions/setup-node v4 compat)
- Add build step in test job (tests need compiled output)
- Install Playwright Chromium with deps so aspire-integration tests run
- Exclude only docs-build test (needs Docker, unavailable on runner)

Supersedes: #851, #852
Copilot AI review requested due to automatic review settings April 5, 2026 16:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

🟢 Impact Analysis — PR #854

Risk tier: 🟢 LOW

📊 Summary

Metric Count
Files changed 1
Files added 0
Files modified 1
Files deleted 0
Modules touched 1

🎯 Risk Factors

  • 1 files changed (≤5 → LOW)
  • 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

ci-workflows (1 file)
  • .github/workflows/squad-insider-publish.yml

This report is generated automatically for every PR. See #733 for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 1906b9b

⚠️ 2 item(s) to address before review

Status Check Details
Single commit 1 commit — clean history
Not in draft Ready for review
Branch up to date Up to date with dev
Copilot review No Copilot review yet — it may still be processing
Changeset present No source files changed — changeset not required
Scope clean No .squad/ or docs/proposals/ files
No merge conflicts No merge conflicts
Copilot threads resolved No Copilot review threads
CI passing 17 check(s) still running

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 5, 2026

🏗️ Architectural Review

⚠️ Architectural review: 1 info.

Severity Category Finding Files
ℹ️ info template-sync Template files changed in .github/workflows/ but not in other template locations. If these templates should stay in sync, consider updating the others too. Changed: .github/workflows/, Unchanged: templates/, .squad-templates/, packages/squad-cli/templates/

Automated architectural review — informational only.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the squad-insider-publish GitHub Actions workflow so it can run on a clean runner by aligning Node.js versioning, ensuring build output exists before tests, and installing Playwright Chromium for integration tests.

Changes:

  • Update all workflow jobs to run on Node.js 22.
  • Add an explicit build step in the test job.
  • Install Playwright Chromium (with OS deps) and run Vitest while excluding the docs build test.

Comment on lines +44 to +46
- name: Build
run: npm run build

Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test job now runs npm run build even though the workflow already has a separate build job that also runs npm run build. Since job workspaces aren’t shared, needs: build doesn’t provide any build artifacts to the test job and this rebuild doubles CI time/cost. Consider either removing the standalone build job (and dropping needs: build), or uploading build outputs from the build job and downloading them in test to avoid rebuilding.

Copilot uses AI. Check for mistakes.
- name: Install Playwright browsers
run: npx playwright install chromium --with-deps

- name: Run tests (skip docs-build — needs Docker unavailable on publish runner)
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step label says the docs-build test is skipped because it “needs Docker”, but test/docs-build.test.ts runs an Astro build via npm run build in the docs/ directory (no Docker usage). If the intent is to skip it because docs dependencies aren’t installed in this workflow (or for time), update the step description accordingly so future readers don’t chase the wrong dependency/root cause.

Suggested change
- name: Run tests (skip docs-build — needs Docker unavailable on publish runner)
- name: Run tests (skip docs-build in publish workflow)

Copilot uses AI. Check for mistakes.
@tamirdresher tamirdresher merged commit 072252a into dev Apr 5, 2026
22 checks passed
diberry pushed a commit that referenced this pull request Apr 5, 2026
#854)

fix(ci): insider publish - Node 22, build step, Playwright install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants