fix(ci): insider publish - Node 22, build step, and Playwright install#854
fix(ci): insider publish - Node 22, build step, and Playwright install#854tamirdresher merged 1 commit intodevfrom
Conversation
🟢 Impact Analysis — PR #854Risk tier: 🟢 LOW 📊 Summary
🎯 Risk Factors
📦 Modules Affectedci-workflows (1 file)
This report is generated automatically for every PR. See #733 for details. |
🛫 PR Readiness Check
|
| Status | Check | Details |
|---|---|---|
| ✅ | Single commit | 1 commit — clean history |
| ✅ | Not in draft | Ready for review |
| ✅ | Branch up to date | Up to date with dev |
| ❌ | Copilot review | No Copilot review yet — it may still be processing |
| ✅ | Changeset present | No source files changed — changeset not required |
| ✅ | Scope clean | No .squad/ or docs/proposals/ files |
| ✅ | No merge conflicts | No merge conflicts |
| ✅ | Copilot threads resolved | No Copilot review threads |
| ❌ | CI passing | 17 check(s) still running |
This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.
🏗️ Architectural Review
Automated architectural review — informational only. |
There was a problem hiding this comment.
Pull request overview
Fixes the squad-insider-publish GitHub Actions workflow so it can run on a clean runner by aligning Node.js versioning, ensuring build output exists before tests, and installing Playwright Chromium for integration tests.
Changes:
- Update all workflow jobs to run on Node.js 22.
- Add an explicit build step in the test job.
- Install Playwright Chromium (with OS deps) and run Vitest while excluding the docs build test.
| - name: Build | ||
| run: npm run build | ||
|
|
There was a problem hiding this comment.
The test job now runs npm run build even though the workflow already has a separate build job that also runs npm run build. Since job workspaces aren’t shared, needs: build doesn’t provide any build artifacts to the test job and this rebuild doubles CI time/cost. Consider either removing the standalone build job (and dropping needs: build), or uploading build outputs from the build job and downloading them in test to avoid rebuilding.
| - name: Install Playwright browsers | ||
| run: npx playwright install chromium --with-deps | ||
|
|
||
| - name: Run tests (skip docs-build — needs Docker unavailable on publish runner) |
There was a problem hiding this comment.
The step label says the docs-build test is skipped because it “needs Docker”, but test/docs-build.test.ts runs an Astro build via npm run build in the docs/ directory (no Docker usage). If the intent is to skip it because docs dependencies aren’t installed in this workflow (or for time), update the step description accordingly so future readers don’t chase the wrong dependency/root cause.
| - name: Run tests (skip docs-build — needs Docker unavailable on publish runner) | |
| - name: Run tests (skip docs-build in publish workflow) |
#854) fix(ci): insider publish - Node 22, build step, Playwright install
What
Proper fix for the insider publish workflow CI failures.
Changes
pm run build\
px playwright install chromium --with-deps\ so aspire-integration tests actually run
Why
The insider publish workflow runs on a clean GitHub Actions runner. Without building first and installing Playwright, the test job fails. Previous PRs (#851, #852) worked around this by skipping Playwright tests entirely — this PR fixes the root cause so the tests validate properly.
Supersedes: #851, #852