fix(test): Docker skip guards + flaky test stabilization (#677)

[diberry]

Cherry-picks the fix from #723. Adds shared Docker skip guard helper and stabilizes flaky tests.

Changes

• New: \ est/helpers/skip-guards.ts\ — shared \dockerSkipReason()\ helper
• Refactored: \ est/aspire-integration.test.ts\ — uses shared helper instead of inline Docker check
• Added: \ est/cli/aspire.test.ts\ — \describe.skipIf\ guard so Docker tests skip gracefully
• Fixed: \ est/template-sync.test.ts\ — timeout 30s → 60s for flaky stability

Testing

• ✅ 162 tests pass (Docker tests skip gracefully without Docker)
• ✅ 5 aspire-integration tests correctly skipped

Original author: @tamirdresher
Closes #677, fixes #582

Part of stale PR triage (diberry#137)

[github-actions]

🟢 Impact Analysis — PR #857

Risk tier: 🟢 LOW

📊 Summary

Metric	Count
Files changed	4
Files added	1
Files modified	3
Files deleted	0
Modules touched	1

🎯 Risk Factors

• 4 files changed (≤5 → LOW)
• 1 module(s) touched (≤1 → LOW)

📦 Modules Affected

tests (4 files)

• test/aspire-integration.test.ts
• test/cli/aspire.test.ts
• test/helpers/skip-guards.ts
• test/template-sync.test.ts

---

This report is generated automatically for every PR. See #733 for details.

[github-actions]

🛫 PR Readiness Check

ℹ️ This comment updates on each push. Last checked: commit 41a93ad

PR Scope: 🔧 Infrastructure

⚠️ 5 item(s) to address before review

Status	Check	Details
❌	Single commit	2 commits — consider squashing before review
✅	Not in draft	Ready for review
❌	Branch up to date	dev is 3 commit(s) ahead — rebase recommended
❌	Copilot review	No Copilot review yet — it may still be processing
✅	Changeset present	No source files changed — changeset not required
✅	Scope clean	No .squad/ or docs/proposals/ files
✅	No merge conflicts	No merge conflicts
❌	Copilot threads resolved	1 unresolved Copilot thread(s) — fix and resolve before merging
❌	CI passing	16 check(s) still running

Files Changed (4 files, +73 −30)

File	+/−
test/aspire-integration.test.ts	+12 −21
test/cli/aspire.test.ts	+25 −8
test/helpers/skip-guards.ts	+35 −0
test/template-sync.test.ts	+1 −1

Total: +73 −30

---

This check runs automatically on every push. Fix any ❌ items and push again.
See CONTRIBUTING.md and PR Requirements for details.

[Copilot]

Pull request overview

This PR cherry-picks the fix from #723 to make Docker-dependent tests skip gracefully when Docker is unavailable (or explicitly disabled) and to reduce flakiness in template sync tests under load.

Changes:

• Introduces a shared Docker skip-guard helper (dockerSkipReason()) for test suites.
• Refactors Aspire integration and CLI Aspire tests to use describe.skipIf(...) with the shared helper.
• Increases the sync-templates.mjs execution test timeout to improve stability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
test/helpers/skip-guards.ts	Adds shared Docker availability detection and skip-reason helper for tests.
test/aspire-integration.test.ts	Replaces inline Docker detection with the shared dockerSkipReason() guard.
test/cli/aspire.test.ts	Wraps Docker availability describe block in a describe.skipIf(...) guard using the shared helper.
test/template-sync.test.ts	Raises exec timeout from 30s to 60s to reduce flakiness under load.

[tamirdresher]

Approved by @tamirdresher — reviewed diff, CI green, changes are clean and well-tested. cc @diberry

[bradygaster]

Closed by #theSquadsquad triage — verified fixed in v0.9.4.