-
-
Notifications
You must be signed in to change notification settings - Fork 372
Test the codebase against php 8.1 #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Darn, FPM 8.1 is not available via apt-get yet. I'll try to figure this out |
|
Hey just FYI in case that helps, I had trouble with FPM too when adding tests for PHP 8 beta: shivammathur/setup-php#280 (comment) |
|
@mnapoli the workflow is fixed for 8.1 but the tests are failing because See the php-src PR php/php-src#6917 I've provided a fix for it, let me know if you think that's ok to it this way. |
| - php: '7.3' | ||
| dependency-version: '--prefer-lowest' | ||
| - php: '8.1' | ||
| platform-reqs: '--ignore-platform-req=php' # see https://github.com/phpspec/prophecy/pull/533#issuecomment-891606803 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still relevant now that the PR has been merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is merged but prophecy is not released and it won't be until php8.1 issues are fixed. I think it can be merged as is and removed when prophecy is compatible (it will be around RC1 apparently).
mnapoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @t-richard!
|
Thank you @t-richard! |
As PHP 8.1 is coming and support is already considered in #980, I think its needed to run tests against 8.1 in the CI to ensure that the code doesn't break and eventually spot something, be it in Bref, php or a downstream dependency.