-
-
Notifications
You must be signed in to change notification settings - Fork 372
PHP 8.1 runtimes #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.1 runtimes #980
Conversation
|
Thanks! We'll likely combine this with our plan on automating the build next week. Did you test if this build is working as expected? |
|
Not yet, it is currently in the build process |
|
When I run How can I ensure this works correctly? |
|
OK we went over these changes, but we're afraid of a long feedback loop of:
Such a feedback loop is very long and takes a lot of time. What would be best instead, before merging, is knowing that the layers do indeed work. One way to do that is to build the layers locally and publish them to your own AWS account ( Then share the layers ARN here, so that people can test it out. Once we are confident the layers are working, we can merge them and publish them. |
|
👌
|
|
Thanks! I shared on twitter too (I won't have time to test today personally): https://twitter.com/brefphp/status/1422185768978681859 |
|
PHP 8.1.0beta2
|
|
PHP 8.1.0beta3
|
|
@mykiwi I'm ok to test it but prior to test lambda layers, I would prefer to make that gradually against our apps:
Do you think it's possible to publish at least Also, as I use some extra php extensions (in fact just one: redis) in many of our apps do you think it's also possible to publish the And @Nyholm... this would imply then to build and publish first docker preview images & layers too 👼 |
|
As soon as |
|
👍 cool! Just to be transparent, the current status of this PR is basically waiting for someone telling us that these layers work 😄 |
|
Actually now that we have the build pipeline fully automated, let's give this a try! Thank you @mykiwi! |
| cd layers/fpm-dev ; docker build -t bref/php-73-fpm-dev --build-arg PHP_VERSION=73 . | ||
| cd layers/fpm-dev ; docker build -t bref/php-74-fpm-dev --build-arg PHP_VERSION=74 . | ||
| cd layers/fpm-dev ; docker build -t bref/php-80-fpm-dev --build-arg PHP_VERSION=80 . | ||
| #cd layers/fpm-dev ; docker build -t bref/php-81-fpm-dev --build-arg PHP_VERSION=81 . # xdebug not ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have been nice to enabling it but without xdebug ATM, WDYT? I can try a PR if 🆗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 sounds good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to rework on it if my free time allows me, 👍 for trying on your side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoever picks this up, consider taking a quick look at https://github.com/brefphp/bref/blob/master/Makefile#L18 to see if it's easy to start publishing php-81 images on Docker Hub, that would help me test PHP 8.1!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry #1008 as an upfix of #1007... but I've also prepared the extra extensions PR brefphp/extra-php-extensions#261
This pull request adds PHP 8.1 runtimes (PHP 8.1.0beta3)
Heavily inspired from #678
To test it: