Skip to content

Conversation

@shouze
Copy link
Contributor

@shouze shouze commented Aug 29, 2021

Related to brefphp/bref#1007

Also related to brefphp/bref#1008, waiting for upfix to be merged

Related to brefphp/bref#1007

Also related to brefphp/bref#1008, waiting for upfix to be merged
@shouze
Copy link
Contributor Author

shouze commented Aug 29, 2021

⚠️ @Nyholm please wait before merge, it's probably a good idea to update to 1.2.13 images once brefphp/bref#1008 get merged

@Nyholm
Copy link
Collaborator

Nyholm commented Aug 30, 2021

Cool cool. Let me know when it is ready to be reviewed.

@shouze shouze marked this pull request as ready for review August 30, 2021 15:31
@shouze
Copy link
Contributor Author

shouze commented Aug 30, 2021

Cool cool. Let me know when it is ready to be reviewed.

This is ok now! 😃

@GrahamCampbell
Copy link
Contributor

Can we support xdebug by compiling from master? https://gitlab.com/GrahamCampbell/PHP/-/blob/8.1/Dockerfile#L5-8

@shouze
Copy link
Contributor Author

shouze commented Aug 30, 2021

Can we support xdebug by compiling from master?

@GrahamCampbell do you mean like that 3328679? 😉

@GrahamCampbell
Copy link
Contributor

do you mean like that

Yes. 🚢

Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@@ -1,5 +1,29 @@
# Change log

## 0.12.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will change this to 0.11.15 before releasing.
There are no BC breaks here.

@Nyholm Nyholm merged commit f5fe449 into brefphp:master Aug 30, 2021
@mnapoli
Copy link
Member

mnapoli commented Aug 30, 2021

Wow xdebug support in PHP 8.1 already, that's crazy 🤯

Amazing stuff here!

@shouze shouze deleted the feat-add-most-php-81-extensions branch August 31, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants