feat(runtimes): build and publish PHP 8.1 docker images #1007
Conversation
Related to https://github.com/brefphp/bref/pull/980/files#r695552502 For now xdebug & blackfire are not included because no php 8.1 version available yet.
runtime/layers/fpm-dev/Dockerfile
Outdated
| RUN cp /tmp/*.so $(php -r "echo ini_get('extension_dir');") | ||
|
|
||
| FROM bref/php-${PHP_VERSION}-fpm | ||
| FROM bref/php-${PHP_VERSION}-fpm as without_extensions |
There was a problem hiding this comment.
Will help for other new php versions upgrade as most of the time blackfire or xdebug are not ready during beta releases.
| # opcache.validate_timestamps=1 : cancels the flag in the base configuration so that files are reloaded | ||
| CMD /opt/bin/php-fpm --nodaemonize --fpm-config /opt/bref/etc/php-fpm.conf -d opcache.validate_timestamps=1 --force-stderr | ||
|
|
||
| FROM without_extensions |
There was a problem hiding this comment.
Why the new FROM here? We would lose the EXPOSE, ENV and everything defined above?
There was a problem hiding this comment.
I've checked, ENV, EXPOSE, CMD & ENTRYPOINT will be inherited from the above, the only difference is that we won't copy extensions (xdebug, blackfire).
There was a problem hiding this comment.
Ohh I think I see it now, thank you!
|
Thanks! I added a minor feedback, and it seems the build is not running in GitHub Actions |
Thanks, everything should be good now. Seems that some versions of docker build previous targets so I moved without_extensions one at first position and fixed the CI |
|
Thank you! Just to be sure: no need for new layers here, right? |
New layers have been published in previous PR so no, only need to publish docker images. |
|
BTW a new tag should be required regarding GitHub action |
|
👍 the new release should have done it by now |
Thanks a lot... but I have bad news, an upfix seems necessary #1008 |
* Adding php 81 for most extensions Related to brefphp/bref#1007 Also related to brefphp/bref#1008, waiting for upfix to be merged * Use 1.2.13 as base bref image * Support xdebug master on PHP 8.1
|
For the record I'm re-enabling the extensions in #1114 |
* Adding php 81 for most extensions Related to brefphp/bref#1007 Also related to brefphp/bref#1008, waiting for upfix to be merged * Use 1.2.13 as base bref image * Support xdebug master on PHP 8.1
2 participants
🐳 will allow to test locally bref with php 8.1 when the docker images will get published 🎉
⚠️ For now xdebug & blackfire are not included because no php 8.1 version available yet.
👉 Related to https://github.com/brefphp/bref/pull/980/files#r695552502