feat: add connection parameter nativeConnectionString #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for when you want to pass connection string AS IS to pg-native which allows the use of features present in libpq but still not impremented in the js drivers
brianc
requested changes
Oct 15, 2022
Owner
brianc
left a comment
brianc
left a comment
There was a problem hiding this comment.
Sorry for the delay here on my part with the review. Can you supply a test case that covers this? I typically don't merge code unless its covered by tests.
|
There is another one PR with the same changes but with tests #2941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for when you want to pass connection string AS IS to pg-native
which allows the use of features present in libpq but still not
implemented in the js drivers
like multihost URI