feat: add connection parameter nativeConnectionString #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Nice! Thanks - sorry for the delay. Will release this today. 😄 |
|
Could you release this feature? @brianc |
thijs
pushed a commit
to thijs/node-postgres
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Evgeniy Novikov <e.p.novikov@tinkoff.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of MR #2751
I copy-pasted the solution itself, but also I have added tests as you asked
Support of nativeConnectionString in some cases could be really useful like
using ConnectionParameters class not always be helpful since it doesn't support all possible variants of the connection string