feat(frontend): added Protection to Frontend by SHREESHANTH99 · Pull Request #32 · bsoc-bitbyte/YDO

SHREESHANTH99 · 2025-07-04T13:45:54Z

Overview

This PR fixes part of [Feature Request]: Add Route Protection to Frontend #25.

This PR does the following:

Adds a reusable component to protect sensitive routes like /home and /profile.

Redirects unauthenticated users to /login.

Renders only inside protected pages (e.g., Home.jsx), cannot be rendered before login is done

##Essential Checklist
The PR title starts with Fix part of #25: followed by a clear summary.

"Allow edits from maintainers" is checked.

The PR is made from a branch not called main or master.

Proof that changes are correct

Uploading Screen Recording 2025-07-04 183758.mp4…

netlify · 2025-07-04T13:45:59Z

✅ Deploy Preview for ydo-bsoc ready!

Name	Link
🔨 Latest commit	`0aae707`
🔍 Latest deploy log	https://app.netlify.com/projects/ydo-bsoc/deploys/6870a334b30a2200087c3309
😎 Deploy Preview	https://deploy-preview-32--ydo-bsoc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

SHREESHANTH99 · 2025-07-05T05:11:52Z

Proof that changes are correct

Screen.Recording.2025-07-04.183758.mp4

SHREESHANTH99 · 2025-07-05T05:16:36Z

@Zapper9982 is it okay.

Zapper9982 · 2025-07-05T05:20:37Z

Can u share the demo after login too ?

SHREESHANTH99 · 2025-07-05T05:39:06Z

Screen.Recording.2025-07-05.110504.mp4

@Zapper9982 i added navbar in home to show you

Zapper9982 · 2025-07-05T06:11:49Z

@SHREESHANTH99 the expected behaviour is that the navbar be served on all routes except the landing and Login.

adding the Navbar component to each route is not a feasible option .

SHREESHANTH99 · 2025-07-05T06:31:08Z

@Zapper9982 should I make it such that it should be available it all other routes automatically except landing and login

Zapper9982 · 2025-07-05T07:28:31Z

@Zapper9982 should I make it such that it should be available it all other routes automatically except landing and login

yes exactly

SHREESHANTH99 · 2025-07-05T07:32:18Z

done should i sent video

SHREESHANTH99 · 2025-07-05T07:39:45Z

Screen.Recording.2025-07-05.130846.mp4

Zapper9982 · 2025-07-06T04:06:00Z

@SHREESHANTH99 can u resolve the merge conflicts

Om-Thorat · 2025-07-06T05:24:21Z

@SHREESHANTH99 fix the build please

Om-Thorat · 2025-07-09T05:45:26Z

Resolve the conflicts as well

SHREESHANTH99 · 2025-07-09T05:59:13Z

Is it okay now

Zapper9982 · 2025-07-09T19:13:51Z

src/App.jsx

+
      <Route path="/callback" element={<Callback />} />
      <Route path="/preloader" element={<Preloader />} />
      <Route path="/profile" element={<ProfilePage />} />


shouldn't the other endpoints have protection too ? Please add the private route components to others too

Only profile and home page right I will add protection to profile too then

Only profile and home page right I will add protection to profile too then

we need protection for every route that will come apart from Home and Login can u implement it like that ? , cause just adding the PrivaterRoute around each route one by one , is redundant and is not production ready .

Navbar be served on all routes except landing and login. Closes bsoc-bitbyte#25

created a profile page which is editable using react usestate with /profile route Closes bsoc-bitbyte#18

- Increase branch and year input box widths for better usability - Fix layout shifts when switching between view and edit modes - Ensure consistent font styling across input elements Closes bsoc-bitbyte#18

made a few changes in the width of the branchinput and year boxes Closes bsoc-bitbyte#18

fixed the position of the x button Fixes bsoc-bitbyte#18

Made changes according to requirement. Closes bsoc-bitbyte#25

* feat: added the preloader * feat: preloader background updated * feat: preloader fixed bg and svg Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com> * feat: preloader fixed bg and svg Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com> * feat: fixed the backgrounds and comments Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com> --------- Signed-off-by: Shirshendu R Tripathi <shirsh8924@gmail.com>

…o requirement. Closes bsoc-bitbyte#25

Zapper9982 · 2025-07-10T07:12:43Z

@SHREESHANTH99 resolve all the conflicts and looks like all the checks have failed .

Zapper9982 · 2025-07-10T07:16:43Z

@SHREESHANTH99 can you explain why have u force pushed ?

SHREESHANTH99 · 2025-07-10T07:53:37Z

@SHREESHANTH99 can you explain why have u force pushed ?

I forgot to merge and sync changes from main before doing commit so I was getting merge conflicts

Made changes according to requirement. Closes bsoc-bitbyte#25

>> >> Made changes according to requirement. >> >> Closes bsoc-bitbyte#25

Resolved merge conflicts. Closes bsoc-bitbyte#25

SHREESHANTH99 · 2025-07-10T08:33:40Z

@Zapper9982 i am getting this [Lint Commit Messages again again again what should i do?

Protected all routes except Landing, Login, and Callback by wrapping routing logic with a central PrivateRoutesWrapper. closes bsoc-bitbyte#25

Zapper9982 · 2025-07-10T11:02:05Z

@Zapper9982 i am getting this [Lint Commit Messages again again again what should i do?

dont worry about it , one of your commit messages were not correctly listed , apart from that its okay dont worry

SHREESHANTH99 · 2025-07-10T11:14:41Z

@Zapper9982 i am getting this [Lint Commit Messages again again again what should i do?

dont worry about it , one of your commit messages were not correctly listed , apart from that its okay dont worry

I made changes of what you asked can you review

Zapper9982 · 2025-07-10T12:10:42Z

src/App.jsx

+        </Route>
+        <Route path="/callback" element={<Callback />} />
+      </Route>
      <Route path="/preloader" element={<Preloader />} />


add the preloaded into the private routes too since , the Login content exactly loads before the preloader starts

OTHER than that looks good

Can you review

…b.com/SHREESHANTH99/YDO into feature/protected-routes

Added protection to preloder. closes bsoc-bitbyte#25

SHREESHANTH99 closed this Jul 4, 2025

SHREESHANTH99 reopened this Jul 4, 2025

Zapper9982 requested a review from Om-Thorat July 6, 2025 04:11

Zapper9982 reviewed Jul 9, 2025

View reviewed changes

SHREESHANTH99 and others added 11 commits July 10, 2025 11:33

feat(frontend): added Protection to Frontend

612c2c8

feat(frontend): add Protection to frontend

082a576

Navbar be served on all routes except landing and login. Closes bsoc-bitbyte#25

feat(frontend): add profile page

0672064

created a profile page which is editable using react usestate with /profile route Closes bsoc-bitbyte#18

style(frontend): fix profile page styling and layout consistency

2e84642

- Increase branch and year input box widths for better usability - Fix layout shifts when switching between view and edit modes - Ensure consistent font styling across input elements Closes bsoc-bitbyte#18

style(frontend): fix profil page styling and layout consistency

be5524b

- Increase branch and year input box widths for better usability - Fix layout shifts when switching between view and edit modes - Ensure consistent font styling across input elements Closes bsoc-bitbyte#18

style(frontend): make a few fixes in css

ccca68e

made a few changes in the width of the branchinput and year boxes Closes bsoc-bitbyte#18

style(frontend): fix tag remove button position

6be4e94

fixed the position of the x button Fixes bsoc-bitbyte#18

feat(frontend): added Protection to Frontend

581b7ad

Made changes according to requirement. Closes bsoc-bitbyte#25

feat(frontend): added Protection to Frontend

b4d9a50

Made changes according to requirement. Closes bsoc-bitbyte#25

feat(frontend): added Protection to Frontend Made changes according t…

7bcc66a

…o requirement. Closes bsoc-bitbyte#25

SHREESHANTH99 force-pushed the feature/protected-routes branch from 05f9582 to 7bcc66a Compare July 10, 2025 07:01

Merge remote-tracking branch 'origin/main' into feature/protected-routes

5775fea

SHREESHANTH99 added 3 commits July 10, 2025 13:29

feat(frontend): added Protection to Frontend

0f4d1f9

Made changes according to requirement. Closes bsoc-bitbyte#25

feat(frontend): added Protection to Frontend

7173bb1

>> >> Made changes according to requirement. >> >> Closes bsoc-bitbyte#25

feat(frontend): resolve merge conflicts

849070d

Resolved merge conflicts. Closes bsoc-bitbyte#25

SHREESHANTH99 force-pushed the feature/protected-routes branch from cf76bc0 to 849070d Compare July 10, 2025 08:28

feat(frontend): added route protection

90d16e3

Protected all routes except Landing, Login, and Callback by wrapping routing logic with a central PrivateRoutesWrapper. closes bsoc-bitbyte#25

Zapper9982 reviewed Jul 10, 2025

View reviewed changes

SHREESHANTH99 added 2 commits July 11, 2025 11:05

Merge branches 'feature/protected-routes' and 'main' of https://githu…

a6b0cbb

…b.com/SHREESHANTH99/YDO into feature/protected-routes

feat(frontend): added preloader into privateroute

0aae707

Added protection to preloder. closes bsoc-bitbyte#25

Zapper9982 merged commit 9a9cd16 into bsoc-bitbyte:main Jul 15, 2025
5 of 6 checks passed

Zapper9982 added BSoC'25 Created for BSoC'25 Difficulty : Hard hard level issue labels Jul 16, 2025

Comments

Conversation

SHREESHANTH99 commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Proof that changes are correct

Uh oh!

netlify bot commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for ydo-bsoc ready!

Uh oh!

SHREESHANTH99 commented Jul 5, 2025

Proof that changes are correct

Uh oh!

SHREESHANTH99 commented Jul 5, 2025

Uh oh!

Zapper9982 commented Jul 5, 2025

Uh oh!

SHREESHANTH99 commented Jul 5, 2025

Uh oh!

Zapper9982 commented Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SHREESHANTH99 commented Jul 5, 2025

Uh oh!

Zapper9982 commented Jul 5, 2025

Uh oh!

SHREESHANTH99 commented Jul 5, 2025

Uh oh!

SHREESHANTH99 commented Jul 5, 2025

Uh oh!

Zapper9982 commented Jul 6, 2025

Uh oh!

Om-Thorat commented Jul 6, 2025

Uh oh!

Om-Thorat commented Jul 9, 2025

Uh oh!

SHREESHANTH99 commented Jul 9, 2025

Uh oh!

Zapper9982 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

SHREESHANTH99 Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

SHREESHANTH99 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 commented Jul 10, 2025

Uh oh!

Zapper9982 commented Jul 10, 2025

Uh oh!

SHREESHANTH99 commented Jul 10, 2025

Uh oh!

SHREESHANTH99 commented Jul 10, 2025

Uh oh!

Zapper9982 commented Jul 10, 2025

Uh oh!

SHREESHANTH99 commented Jul 10, 2025

Uh oh!

Zapper9982 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

SHREESHANTH99 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

SHREESHANTH99 commented Jul 4, 2025 •

edited

Loading

netlify bot commented Jul 4, 2025 •

edited

Loading

Zapper9982 commented Jul 5, 2025 •

edited

Loading