Conversation
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Marking as draft as there are still some TODOs in the doc (links to pages that don't exist). But I think this is ready for some test-driving... |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
AidanDelaney
left a comment
AidanDelaney
left a comment
There was a problem hiding this comment.
In general, I like these docs. They're well written. There are a few TODO's to tidy up and I'd like a pack release and the samples PR to land before we land these docs. I have ideas on how to restructure docs, but I think concrete docs like these are more important than waiting for abstract ideas to become real. We might restructure these docs if we refactor the presentation of all docs. In short, these are great :)
| ``` | ||
| . | ||
| ├── extension.toml <- similar to a buildpack buildpack.toml | ||
| ├── bin | ||
| │ ├── detect <- similar to a buildpack ./bin/detect | ||
| │ ├── generate <- similar to a buildpack ./bin/build | ||
| ``` | ||
|
|
content/docs/features/dockerfiles.md
Outdated
| extensions in builds - will need additional updating to propagate changes such as a switched run image back to the | ||
| appropriate resource to avoid breaking rebase. |
There was a problem hiding this comment.
Do you think readers of this document will be interested in technical details behinf kpack or will they be interested in a supported/not-supported decision?
| extensions in builds - will need additional updating to propagate changes such as a switched run image back to the | |
| appropriate resource to avoid breaking rebase. | |
| extensions in builds - will need additional updating to propagate changes. |
There was a problem hiding this comment.
I think a support/not-supported is what I'd care about and then a link to more details on how to enable it.
There was a problem hiding this comment.
I've restructured it a bit... LMK how it looks now
| ### 0. Setup workspace directory | ||
|
|
||
| * `workspace=<your preferred workspace directory>` | ||
|
|
||
| ### 1. Clone the pack repo and build it (TODO: remove when pack with extensions-phase-2 support is released) | ||
|
|
||
| * `cd $workspace` | ||
| * `git clone git@github.com:buildpacks/pack.git` | ||
| * `cd pack` | ||
| * `git checkout extensions-phase-2` | ||
| * `make clean build` | ||
|
|
There was a problem hiding this comment.
I'm really hoping we can get a pack release out before these docs land. Then you don't have to explain this to users.
| * `cd $workspace` | ||
| * `git clone git@github.com:buildpacks/samples.git` | ||
| * `cd samples` | ||
| * `git checkout extensions-phase-2` (TODO: remove when `extensions-phase-2` merged) |
There was a problem hiding this comment.
We should really merge this before releaing the docs.
Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net> Co-authored-by: Terence Lee <hone02@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
I added a buildpack & platform migration guide and added some stuff about shell removal / overridable process args in the process. Hopefully it doesn't make the PR too difficult to parse. Still some sections to be added which I will get to shortly! |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
Closing in favor of #527 |
3 participants
Readable