Skip to content

Docs for Dockerfiles#527

Merged
AidanDelaney merged 30 commits intomainfrom
extensions-phase-2-rc2
Feb 10, 2023
Merged

Docs for Dockerfiles#527
AidanDelaney merged 30 commits intomainfrom
extensions-phase-2-rc2

Conversation

@natalieparellano
Copy link
Copy Markdown
Member

@natalieparellano natalieparellano commented Oct 24, 2022 •
edited
Loading

Also includes migration guides for platform 0.10 and buildpack 0.9

Supersedes #526

Natalie Arellano and others added 10 commits October 12, 2022 15:25
Initial docs for Dockerfiles
7c37ccf 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Cleanup some TODOs
87e90a0 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Wording
698734e 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@AidanDelaney @hone
Apply suggestions from code review
9651504 
Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net>
Co-authored-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Add platform migration guide
88b20f4 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Add buildpack migration guide (stub)
58fff0b 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Minor edits
5f3e7e9 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Minor edits
2c1a5dc 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Minor edits
faa06a4 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Move tutorial to create extension guide
7da2dd1 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano requested a review from a team as a code owner October 24, 2022 17:39
@natalieparellano natalieparellano mentioned this pull request Oct 24, 2022
Closed
@natalieparellano
Copy link
Copy Markdown
Member Author

natalieparellano commented Oct 24, 2022

Apologies for yet another PR - I pointed a few people toward the old one, and didn't want to change it too drastically.

I believe I've addressed all the TODOs that were there previously - at this point, the only thing that should block a merge is actually releasing the needed components (now marked FIXME).

Natalie Arellano added 4 commits October 24, 2022 15:02
Improve formatting
e7cb3e2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Minor fixes
10480f2 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Update to rc.2
c665ad1 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Minor fixes
da1771e 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano linked an issue Nov 10, 2022 that may be closed by this pull request
Document Dockerfiles feature (phase 1) #501
Closed
5 tasks
@natalieparellano natalieparellano mentioned this pull request Nov 10, 2022
Closed
4 tasks
Natalie Arellano added 2 commits November 10, 2022 16:09
Update to released lifecycle
4f82d4f 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Clarify inputs to the extender
3f20b32 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano linked an issue Dec 2, 2022 that may be closed by this pull request
[RFC #0093] Remove Shell-Specific Logic #391
Closed
Natalie Arellano added 2 commits December 13, 2022 12:47
@natalieparellano
Copy link
Copy Markdown
Member Author

natalieparellano commented Dec 13, 2022

@buildpacks/learning-maintainers this should be good to go now (removed references to pack and samples branches)

Change all references to installed pack
f7f1ab5 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
joe-kimmel-vmw
joe-kimmel-vmw reviewed Jan 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@joe-kimmel-vmw joe-kimmel-vmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @natalieparellano - this tutorial really helped me understand the run and build extensions! I left you an embarrassingly long list of notes - one for each time i had at least a little confusion :) Please feel free to pick and choose whether / which to address, and don't let me slow down you publishing this content!

content/docs/extension-author-guide/create-extension/run-dockerfile.md Outdated

#### generate

`cat $workspace/samples/extensions/curl/bin/generate` - the extension generates a `run.Dockerfile` that switches the run image to
Copy link
Copy Markdown
Contributor

@joe-kimmel-vmw joe-kimmel-vmw Jan 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not obvious to me why it's important that this is in a script? is the point that we used to have a different dockerfile? in the next step we do have a pre-made dockerfile, right?

Copy link
Copy Markdown
Member Author

@natalieparellano natalieparellano Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually static Dockerfiles are a thing! This will be documented as part of #530

Natalie Arellano added 2 commits February 1, 2023 10:36
Updates from PR review
65f83e5 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Add ugo tests
94d095b 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano natalieparellano force-pushed the extensions-phase-2-rc2 branch 6 times, most recently from f5fbda7 to 56159d9 Compare February 3, 2023 21:31
Try to fix ugo
fcdb0ae 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Natalie Arellano added 2 commits February 3, 2023 20:23
Add guidance to make it work on Mac
f5d2b3c 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Merge branch 'main' into extensions-phase-2-rc2
319eea6
@natalieparellano
Copy link
Copy Markdown
Member Author

natalieparellano commented Feb 4, 2023

@buildpacks/learning-maintainers I think this is ready for another look

AidanDelaney
AidanDelaney reviewed Feb 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic. I've left a small number of nitpick comments. Please either accept or reject and we can land this early next week. It's a great doc.

Natalie Arellano added 3 commits February 6, 2023 11:13
Clarify registry namespace and remove var
235c306 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Update pack config
70820f5 
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Merge branch 'main' into extensions-phase-2-rc2
6c9e542
@natalieparellano natalieparellano mentioned this pull request Feb 6, 2023
Closed
4 tasks
AidanDelaney
AidanDelaney approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natalieparellano
Copy link
Copy Markdown
Member Author

natalieparellano commented Feb 9, 2023

Should we merge this one?

@AidanDelaney AidanDelaney merged commit b362c49 into main Feb 10, 2023
@AidanDelaney AidanDelaney deleted the extensions-phase-2-rc2 branch February 10, 2023 07:28
github-actions bot pushed a commit that referenced this pull request Feb 10, 2023
@AidanDelaney
Merge pull request #527 from buildpacks/extensions-phase-2-rc2
00bf3de 
Docs for Dockerfiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sambhav sambhav sambhav left review comments

@AidanDelaney AidanDelaney AidanDelaney approved these changes

+1 more reviewer

@joe-kimmel-vmw joe-kimmel-vmw joe-kimmel-vmw left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document Dockerfiles feature (phase 1) [RFC #0093] Remove Shell-Specific Logic

4 participants

@natalieparellano @AidanDelaney @sambhav @joe-kimmel-vmw