overlay: replace jsonpath by the more recent (and typed) jsonpathly#673
Merged
paulRbr merged 1 commit intobump-sh:mainfrom Mar 13, 2025
Merged
Conversation
Polo2
reviewed
Mar 13, 2025
Member
Polo2
left a comment
Polo2
left a comment
There was a problem hiding this comment.
Thanks for this json-bump, I left two small comments at first sight, and as discussed, we'll need more refacto to clarify what happens when overlay action is executed.
paulRbr
force-pushed
the
upgrade-jsonpath-with-esm-mode
branch
from
6a2c4a1 to
b5e9baf
Compare
Polo2
approved these changes
Mar 13, 2025
Member
Polo2
left a comment
Polo2
left a comment
There was a problem hiding this comment.
Thanks for pair review session, glad to approve with small clarification suggestions.
paulRbr
force-pushed
the
upgrade-jsonpath-with-esm-mode
branch
2 times, most recently
from
6fca347 to
d45e037
Compare
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
paulRbr
force-pushed
the
upgrade-jsonpath-with-esm-mode
branch
from
d45e037 to
2597c4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The currently used
jsonpathlib is pretty old and unmaintained (lastcommits 4 years ago), and even more problematic it causes issues to
upgrade our github action as that lib has an inconsistant use of
'require' and doesn't seem to work well with the packaging
step (rollup) of the github action.
Hopefully this upgrade (and change of lib) should let us a clean
upgrade of the GH action to an ESM version 🤞
As I re-wrote the way we apply overlays I also took the opportunity to fix #588 in this change.