upgrade: update dependencies and use Node 20#508
Merged
paulRbr merged 9 commits intobump-sh:masterfrom Mar 14, 2025
Merged
Conversation
5848ca9 to
29b1b5d
Compare
29b1b5d to
7f3b23e
Compare
This was
linked to
issues
Jan 21, 2025
Closed
9a9000f to
0cce878
Compare
3025e7a to
f0fb677
Compare
paulRbr
commented
Jan 30, 2025
f0fb677 to
9f32693
Compare
fbraure
reviewed
Jan 30, 2025
Contributor
fbraure
left a comment
There was a problem hiding this comment.
LGTM
Thanks a lot for this huge work 🙏
fbraure
approved these changes
Jan 30, 2025
bfa73b4 to
b8746e0
Compare
Contributor
Member
Author
|
Hi Phil, thanks for the ping. I indeed would love to be able to merge this in, but there's still an issue in the packaging with the new ESM mode which is driving me crazy 😅. I've had to leave it as is for now, but it's almost there. Luckily I should have some time to look at it and merge this ASAP (definitely will do in march. Thanks for the heads up |
paulRbr
added a commit
to paulRbr/cli
that referenced
this pull request
Mar 13, 2025
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
paulRbr
added a commit
to paulRbr/cli
that referenced
this pull request
Mar 13, 2025
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
paulRbr
added a commit
to paulRbr/cli
that referenced
this pull request
Mar 13, 2025
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
paulRbr
added a commit
to paulRbr/cli
that referenced
this pull request
Mar 13, 2025
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
paulRbr
added a commit
to paulRbr/cli
that referenced
this pull request
Mar 13, 2025
The currently used `jsonpath` lib is pretty old and unmaintained (last commits 4 years ago), and even more problematic it causes issues to [upgrade our github action](bump-sh/github-action#508) as that lib has an inconsistant use of 'require' and doesn't seem to work well with the packaging step (rollup) of the github action. Hopefully this upgrade (and change of lib) should let us a clean upgrade of the GH action to an ESM version 🤞
a95208f to
70f9e88
Compare
Down the rabbit hole of ESM...
Instead of manually setting an extra env var for a custom user agent, let's properly use oclif's configuration to be able to read the current repos' package.json. Thus the user agent sent by the github action will include the package.json's `name` value.
70f9e88 to
22fe171
Compare
22fe171 to
5d86869
Compare
Member
Author
|
CI is green, and full integration testing of this branch seems to work fine 🎉 🎉 🎉 (😌 pfiou it was a much longer road than expected 😅) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs of unit tests
Logs of running the action with `local-action` package