Skip to content

Don't fail parsing on @feature and @since gates.#329

Merged
thomastaylor312 merged 1 commit intobytecodealliance:mainfrom
dmvk:annotations
Sep 4, 2024
Merged

Don't fail parsing on @feature and @since gates.#329
thomastaylor312 merged 1 commit intobytecodealliance:mainfrom
dmvk:annotations

Conversation

@dmvk
Copy link
Contributor

@dmvk dmvk commented Aug 27, 2024

This PR adds basic (= doesn't fail parsing) support for WebAssembly/component-model#332. It's basically just a wit-parser version bump.

@dmvk dmvk force-pushed the annotations branch 2 times, most recently from 4f6efdc to 46a1bd6 Compare August 27, 2024 07:30
Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in!

export_macro_name: settings.export_macro_name.clone(),
pub_export_macro: settings.pub_export_macro,
generate_unused_types: settings.generate_unused_types,
// todo - add support for these settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #332 to track this TODO

@thomastaylor312 thomastaylor312 merged commit 1c4f776 into bytecodealliance:main Sep 4, 2024
mergify bot referenced this pull request in andrzejressel/pulumi-gestalt Sep 6, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [cargo-component](https://redirect.github.com/bytecodealliance/cargo-component) | minor | `0.15.0` -> `0.16.0` |

---

### Release Notes

<details>
<summary>bytecodealliance/cargo-component (cargo-component)</summary>

### [`v0.16.0`](https://redirect.github.com/bytecodealliance/cargo-component/releases/tag/v0.16.0)

[Compare Source](https://redirect.github.com/bytecodealliance/cargo-component/compare/v0.15.0...v0.16.0)

#### What's Changed

-   feat(\*)!: Uses wasm-pkg-client for loading dependencies by [@&#8203;thomastaylor312](https://redirect.github.com/thomastaylor312) in [https://github.com/bytecodealliance/cargo-component/pull/322](https://redirect.github.com/bytecodealliance/cargo-component/pull/322)
-   feat(\*)!: Adds back support for the offline flag by [@&#8203;thomastaylor312](https://redirect.github.com/thomastaylor312) in [https://github.com/bytecodealliance/cargo-component/pull/328](https://redirect.github.com/bytecodealliance/cargo-component/pull/328)
-   Don't fail parsing on `@feature` and `@since` gates. by [@&#8203;dmvk](https://redirect.github.com/dmvk) in [https://github.com/bytecodealliance/cargo-component/pull/329](https://redirect.github.com/bytecodealliance/cargo-component/pull/329)
-   ref(\*)!: Updates all code to use the new publish functionality in wkg by [@&#8203;thomastaylor312](https://redirect.github.com/thomastaylor312) in [https://github.com/bytecodealliance/cargo-component/pull/331](https://redirect.github.com/bytecodealliance/cargo-component/pull/331)
-   updated wasm-pkg-client dep version 0.5.0 by [@&#8203;calvinrp](https://redirect.github.com/calvinrp) in [https://github.com/bytecodealliance/cargo-component/pull/334](https://redirect.github.com/bytecodealliance/cargo-component/pull/334)

#### New Contributors

-   [@&#8203;dmvk](https://redirect.github.com/dmvk) made their first contribution in [https://github.com/bytecodealliance/cargo-component/pull/329](https://redirect.github.com/bytecodealliance/cargo-component/pull/329)

**Full Changelog**: bytecodealliance/cargo-component@v0.15.0...v0.16.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/andrzejressel/pulumi-wasm).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants