This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Added a flag to canonicalize_nans#405
Merged
pchickey merged 3 commits intobytecodealliance:masterfrom Jan 30, 2020
Merged
Conversation
pchickey
approved these changes
Jan 30, 2020
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Looks good to me. Its probably time for a refactor that puts all these configuration options to Compiler::new behind a Config struct, so we don't have to keep tacking on additional args, but we can merge this as-is and work on that separately.
data-pup
pushed a commit
that referenced
this pull request
Feb 13, 2020
#405 introduced a new option to support NaNs canonicalization in the compiler. Unfortunately, `LucetcOpts` was not updated properly to support the new flag in the public API. This change fixes that issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to be able to run Lucet deterministically across machines and to do this I need canonicalized NaNs. I couldn't see a good existing data structure that was an argument for this constructor that this would slot in to, but I'm very open to suggestions! 9 arguments might be too many.