This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Extend LucetOpt to support canonicalize_nans flag#423
Merged
data-pup merged 1 commit intobytecodealliance:masterfrom Feb 13, 2020
roman-kashitsyn:roman/lucetopt-canonicalize-nans
Merged
Extend LucetOpt to support canonicalize_nans flag#423data-pup merged 1 commit intobytecodealliance:masterfrom roman-kashitsyn:roman/lucetopt-canonicalize-nans
data-pup merged 1 commit intobytecodealliance:masterfrom
roman-kashitsyn:roman/lucetopt-canonicalize-nans
Conversation
#405 introduced a new option to support NaNs canonicalization in the compiler. Unfortunately, `LucetcOpts` was not updated properly to support the new flag in the public API. This change fixes that issue.
cratelyn
approved these changes
Feb 13, 2020
Member
cratelyn
left a comment
cratelyn
left a comment
There was a problem hiding this comment.
Nice catch, thank you @roman-kashitsyn! 🙂
data-pup
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#405 introduced a new option to support NaNs canonicalization in the compiler.
Unfortunately,
LucetcOptswas not updated properly to support the new flag in the public API. This change fixes that issue.