This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Remove lucet-runtime from crates tested by GitHub Actions#528
Merged
fst-crenshaw merged 3 commits intomasterfrom May 20, 2020
Merged
Remove lucet-runtime from crates tested by GitHub Actions#528fst-crenshaw merged 3 commits intomasterfrom
lucet-runtime from crates tested by GitHub Actions#528fst-crenshaw merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are using CircleCI to test
lucet-runtime. We've been needing a way to test theuserfaultfdimplementation of Regions. The tests can't run on the containers supplied by GitHub Actions because the containers don't have the privileges necessary to use the kernel mechanisms foruserfaultfd.The GitHub Actions tests are still failing, tho. And I worry about conveying a wrong message in CI Results. So I'd like to remove the failing tests that are tested by CircleCI.