This repository was archived by the owner on Mar 24, 2022. It is now read-only.
Closed
Conversation
…uilding macros live
Contributor
Author
|
cc @pchickey because I think you'd best know if I've misunderstood the github action, or if this is a ✔️ change. |
Contributor
Author
|
|
Contributor
Author
|
@fst-crenshaw pointed out that this was originally added (with good discussion!) in #528 - this is me getting ahead of myself on a Friday afternoon, sorry 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I found a typo in some of our yaml programming.CRATES_NOT_TESTEDincludedlucet-runtime, but that's where the runtime tests are instantiated and run. Instead, we should ignorelucet-runtime-testsfor testing (though not strictly necessary - there are no tests in there anyway).Edit: not a typo, this is very much intended: we don't want to run tests for
UffdRegionon github actions, because the Linux there doesn't support that kernel API.I think this is why #554 got as far as the
lucet-objdumpsmoke test before failing, since from a quick eyeball the tests that are run either test details of Cranelift state, module translation state, or use mock modules.lucet-runtimeis the only place we actually load up a real honest-to-goodnessDlModule, which I believe should fail on #554 for to-be-determined weirdness betweenlldandlucetc's choices of relocation.Independently testing that
lucet-runtimereally was not being tested by waiting on CI for this very cool new test I wrote.