Skip to content
This repository was archived by the owner on Mar 24, 2022. It is now read-only.

we should test lucet-runtime!#560

Closed
iximeow wants to merge 1 commit intomainfrom
ixi/any-crate-can-have-tests-if-you-believe
Closed

we should test lucet-runtime!#560
iximeow wants to merge 1 commit intomainfrom
ixi/any-crate-can-have-tests-if-you-believe

Conversation

@iximeow
Copy link
Contributor

@iximeow iximeow commented Jun 27, 2020

I think I found a typo in some of our yaml programming. CRATES_NOT_TESTED included lucet-runtime, but that's where the runtime tests are instantiated and run. Instead, we should ignore lucet-runtime-tests for testing (though not strictly necessary - there are no tests in there anyway).

Edit: not a typo, this is very much intended: we don't want to run tests for UffdRegion on github actions, because the Linux there doesn't support that kernel API.

I think this is why #554 got as far as the lucet-objdump smoke test before failing, since from a quick eyeball the tests that are run either test details of Cranelift state, module translation state, or use mock modules. lucet-runtime is the only place we actually load up a real honest-to-goodness DlModule, which I believe should fail on #554 for to-be-determined weirdness between lld and lucetc's choices of relocation.

Independently testing that lucet-runtime really was not being tested by waiting on CI for this very cool new test I wrote.

@iximeow iximeow requested a review from pchickey June 27, 2020 00:53
@iximeow
Copy link
Contributor Author

iximeow commented Jun 27, 2020

cc @pchickey because I think you'd best know if I've misunderstood the github action, or if this is a ✔️ change.

@iximeow
Copy link
Contributor Author

iximeow commented Jun 27, 2020

edit: the very cool test doesn't fail github actions on main, whoops. Circle and Mac actions still run lucet-runtime tests so we got coverage on commits that got a ✔️ by CI. Working as intended, see OP

@iximeow iximeow closed this Jun 27, 2020
@iximeow
Copy link
Contributor Author

iximeow commented Jun 27, 2020

@fst-crenshaw pointed out that this was originally added (with good discussion!) in #528 - this is me getting ahead of myself on a Friday afternoon, sorry 😸

@iximeow iximeow deleted the ixi/any-crate-can-have-tests-if-you-believe branch June 27, 2020 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant