Add a third register class#126
Conversation
For machines with completely separate vector registers it is useful to have a third register class.
cfallin
left a comment
There was a problem hiding this comment.
This looks great -- thanks!
Once this merges, I'm happy to r+ another PR to bump the version. I think this is a semver break because we added an enum item to RegClass, so that'd be 0.8.0. I'm happy to cargo publish then and we can pull it into Cranelift.
(Incidentally, on the Cranelift side we'll need to bump this constant to allow representing Vec-class pregs in instructions. The verbiage there is a bit out-of-date as the preg-as-vreg index range isn't "pinned" per se, just an encoding; but we can refine in a separate CL PR!)
|
@afonso360 one thing I realized when discussing another regalloc-related question: the |
👋 Hey,
For machines with completely separate vector registers it is useful to have a separate third register class. It looks like we now have encoding space to support that.
I've run all 5 fuzzers for about a couple of hours, and nothing showed up.
Fixes: #47