Fix parsing of empty element func segments#309
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Aug 5, 2021
Merged
Fix parsing of empty element func segments#309alexcrichton merged 1 commit intobytecodealliance:mainfrom
func segments#309alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This fixes an issue where `(elem func)` was parsed as `(elem funcref)` which meant we couldn't distinguish the two nodes in the AST. The fix is to force the usage of index-based elements if `func` is used.
alexcrichton
pushed a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Nov 16, 2022
* Rename `canonical_abi_realloc` to `cabi_realloc`. This follows the current Canonical ABI. This doesn't rename `canonical_abi_free`, as that's expected to be removed when post-return functions are implemented. * Rename the "expected" type to "result". This follows the current Canonical ABI. * Implement function and value type name mangling. This implements the name-mangling scheme in the current canonical ABI, with the modification proposed in WebAssembly/component-model#104, though that can be easily removed if the proposal is declined. * Use name mangling in the bindings generators. * Use the export base name rather than the mangled name for python identifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
(elem func)was parsed as(elem funcref)which meant we couldn't distinguish the two nodes in the AST. The fix is
to force the usage of index-based elements if
funcis used.