Skip to content

Fix parsing of empty element func segments #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Aug 5, 2021
Merged

Fix parsing of empty element func segments #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/wast/src/ast/table.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,15 +188,15 @@ impl<'a> Parse<'a> for ElemPayload<'a> {

impl<'a> ElemPayload<'a> {
fn parse_tail(parser: Parser<'a>, ty: Option<ast::RefType<'a>>) -> Result<Self> {
let ty = match ty {
let (must_use_indices, ty) = match ty {
None => {
parser.parse::<Option<kw::func>>()?;
ast::RefType::func()
(true, ast::RefType::func())
}
Some(ty) => ty,
Some(ty) => (false, ty),
};
if let ast::HeapType::Func = ty.heap {
if parser.peek::<ast::IndexOrRef<kw::func>>() {
if must_use_indices || parser.peek::<ast::IndexOrRef<kw::func>>() {
let mut elems = Vec::new();
while !parser.is_empty() {
elems.push(parser.parse::<ast::IndexOrRef<_>>()?.0);
Expand Down
6 changes: 6 additions & 0 deletions tests/local/empty-elem.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
(module
(elem)
(elem func)
(elem funcref)
(elem declare func)
(elem declare funcref))