support configuring tail calls#205
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Feb 21, 2024
womeier:main
Merged
support configuring tail calls#205alexcrichton merged 2 commits intobytecodealliance:mainfrom womeier:main
alexcrichton merged 2 commits intobytecodealliance:mainfrom
womeier:main
Conversation
Member
|
Thanks! In terms of timing for this, is this ok for you to delay for a month-or-so until the Wasmtime 18 release? Wasmtime 17 will be released in a few days but won't have bytecodealliance/wasmtime#7811, that's slated for the Wasmtime 18 release on merge which will be released on Feb 20. |
Member
|
I've rebased this and fixed a conflict after the Wasmtime 18 update and I'll merge this for that release, thanks again for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring tail calls (Closes #204),
it depends on the change to the C api here: bytecodealliance/wasmtime#7811,
without the change, the CI fails as expected with:
[...] _libwasmtime.so: undefined symbol: wasmtime_config_wasm_tail_call_set.