c-api: expose tail call configuration option in c api#7811
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Jan 24, 2024
womeier:main
Merged
c-api: expose tail call configuration option in c api#7811alexcrichton merged 1 commit intobytecodealliance:mainfrom womeier:main
alexcrichton merged 1 commit intobytecodealliance:mainfrom
womeier:main
Conversation
Member
|
Looks great to me, thanks! Apologies for the documentation but it's outdated. Nowadays the correct invocation is with |
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Contributor
Author
|
Thanks for the quick response @alexcrichton! I created a PR with the changes to the python bindings, they work as expected together, i.e. I can run my wasm module with tail calls using the python lib :) |
alexcrichton
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tail call proposal configuration is not yet exposed by the C api.
This change intends to allow configuring the option in e.g. the python library bindings:
bytecodealliance/wasmtime-py#204
I wanted to test this change doing the following:
Following the docs, I ran
cargo build --release --manifest-path crates/c-api/Cargo.tomlwhich should placelibwasmtime.{a,so}intarget/release.The command succeeded, but the file is not generated (and I cannot find libwasmtime.so with
find).I thus didn't test the change further than the fact that it compiles, in particular I didn't yet test the changewith the python library.
Tested to work together with the PR: bytecodealliance/wasmtime-py#205 adjusting the python bindings.