Enable cranelift-codegen's new all-arch feature to maintain full architecture support by default#193
Conversation
|
This looks good! We can merge this once the Cranelift PR lands. |
|
@sunfishcode @bnjbvr Bump -- with the corresponding Cranelift PR merged, this should also be integrated to maintain the same level of support. |
|
@tschneidereit do you know if we can run this through the new CI pipeline? I would be surprised if this breaks something but I'd still like to see the CI green before merging it. |
|
@steveej apologies for the late reply! The new CI should run automatically for all new PRs/new commits in PRs, but you can also trigger it manually like so: /AzurePipelines run |
|
Unfortunately that doesn't seem to have worked :( Pushing a new commit here should work, though |
mbestavros
force-pushed
the
architecture-control
branch
2 times, most recently
from
88ee8de to
8f93d38
Compare
|
@steveej @sunfishcode The current test failures look related to the current 0.40 release of Is this a situation where we'd want to merge after the next Cranelift release? |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 193 in repo CraneStation/wasmtime |
mbestavros
force-pushed
the
architecture-control
branch
2 times, most recently
from
962496d to
3867c77
Compare
mbestavros
force-pushed
the
architecture-control
branch
from
3867c77 to
a925b4d
Compare
|
@sunfishcode Tests look like they pass now since the corresponding Cranelift commit is live -- is this ready to merge? |
|
Yep, looks good. |
Account for virtual sp adjustments
Implement the encoded spec ops `clz` and `rev`. Use them to verify the `clz` and `ctz` lowerings. Updates avanhatt#42 #34 Co-authored-by: Vaishu Chintam <jc103@wellesley.edu>
…n-diff-smaller Reduce diff with main in wit-bindgen
4 participants
This quick patch goes along with the corresponding PR in Cranelift adding the
all-archfeature.The changes in the linked PR will remove all architectural support by default, allowing dependent projects (such as Wasmtime) to specify exactly which architectures they want to support. In mainline Wasmtime's case, full architectural support is desired, so this patch will simply maintain existing functionality once the Cranelift changes are merged in.
Tagging @sunfishcode @npmccallum @steveej @alexcrichton for review.