Say "memory" instead of "__wasi_memory" in error messages.#264
Merged
kubkon merged 1 commit intobytecodealliance:masterfrom Aug 8, 2019
Merged
Say "memory" instead of "__wasi_memory" in error messages.#264kubkon merged 1 commit intobytecodealliance:masterfrom
kubkon merged 1 commit intobytecodealliance:masterfrom
Conversation
While the "__wasi_memory" name is something we considered, the name currently being used for the memory exported to WASI is "memory", so adjust the error message accordingly.
Member
|
LGTM, and this is actually good to know ;-) |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
* Refactor test imports * Fix formatting
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
Dec 9, 2024
This PR provides the missing piece to support `switch` instructions, by adding the necessary codegen (but only for the optimized implementation, support in the baseline implementation is not included). Thus, the main change is the addition of `wasmtime_cranelift::wasmfx::optimized::translate_switch`. In general, the implementation piggybacks on bytecodealliance#256: On `resume`, we now fill the `HandlerList` with _m_ entries for all tags with suspend handlers, followed by _n_ entries for all tags with switch handlers. The `search_handler` code is changed so that on `suspend` and `switch`, we look in the correct part of the `HandlerList`. We could use two separate `HandlerLists` instead, but then we would have yet another allocation to manage, so putting both kinds of tags into the same list, and then only searching part of it seems preferable. A few more notes: - `translate_resume` and `translate_switch` now return a `WasmResult`. This is used so that the baseline implementation can bail out without needing to `panic`. - The test runner in `stack_switchting.rs` now takes an extra parameter that allows us to enable the gc proposal, which is required for the tests using recursive types. --------- Co-authored-by: Daniel Hillerström <daniel.hillerstrom@ed.ac.uk>
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Emit final solver `(exit)` command, to trigger the subprocess to exit. This is motivated by parallelization, and an early attempt that appeared to be leaking `cvc5` subprocesses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the "__wasi_memory" name is something we considered, the name
currently being used for the memory exported to WASI is "memory", so
adjust the error message accordingly.