Skip to content

Say "memory" instead of "__wasi_memory" in error messages. #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubkon merged 1 commit into from
Aug 8, 2019
Merged

Say "memory" instead of "__wasi_memory" in error messages. #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions wasmtime-wasi-c/src/translate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ unsafe fn decode_ptr(
// Ok, translate the address.
Ok((((*definition).base as usize) + (ptr as usize)) as *mut u8)
}
// No export named "__wasi_memory", or the export isn't a memory.
// No export named "memory", or the export isn't a memory.
// FIXME: Is EINVAL the best code here?
x => {
println!(
"!!! no export named __wasi_memory, or the export isn't a mem: {:?}",
"!!! no export named \"memory\", or the export isn't a mem: {:?}",
x
);
Err(host::__WASI_EINVAL as host::__wasi_errno_t)
Expand Down
2 changes: 1 addition & 1 deletion wasmtime-wasi/src/syscalls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fn get_memory(vmctx: &mut VMContext) -> Result<&mut [u8], host::__wasi_errno_t>
)),
x => {
println!(
"!!! no export named __wasi_memory, or the export isn't a mem: {:?}",
"!!! no export named \"memory\", or the export isn't a mem: {:?}",
x
);
Err(host::__WASI_EINVAL)
Expand Down